Skip to content

Various fixes, part 4#962

Merged
quietbits merged 18 commits into
typescript-migrationfrom
some-fixes-4
Apr 2, 2026
Merged

Various fixes, part 4#962
quietbits merged 18 commits into
typescript-migrationfrom
some-fixes-4

Conversation

@quietbits

@quietbits quietbits commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Medium items 1-5 from the doc.

@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown

Size Change: +3.6 kB (+0.21%)

Total Size: 1.76 MB

📦 View Changed
Filename Size Change
dist/stellar-base.cjs.js 697 kB +1.45 kB (+0.21%)
dist/stellar-base.js 717 kB +1.48 kB (+0.21%)
dist/stellar-base.min.js 345 kB +675 B (+0.2%)

compressed-size-action

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends SDK behavior and tests to handle additional edge cases around Soroban formatting, SCVal map ordering, muxed-account destinations in SAC transfers, and signer-key support for revoke sponsorship.

Changes:

  • Allow addSacTransferOperation to accept muxed (M...) destinations by extracting the base (G...) address for ledger key construction.
  • Fix Soroban.formatTokenAmount for negative values that require zero-padding, and make SCVal map sorting deterministic (codepoint/byte-like order).
  • Add stricter runtime validation for setTrustLineFlags flag values and add ed25519SignedPayload support for revoke-signer sponsorship (create + deserialize).

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/transaction_builder.ts Uses extractBaseAddress so muxed destinations can be used for footprint ledger keys.
src/soroban.ts Preserves/returns negative sign correctly when formatting token amounts.
src/scval.ts Replaces localeCompare with deterministic string ordering for map sorting.
src/operations/set_trustline_flags.ts Enforces that provided flag values are boolean (or undefined).
src/operations/revoke_sponsorship.ts Adds support for ed25519SignedPayload signer keys.
src/operations/types.ts Extends RevokeSignerOpts to include Ed25519SignedPayloadSignerOpt.
src/operation.ts Adds decoding support for signerKeyTypeEd25519SignedPayload.
test/unit/transaction_builder.test.ts Adds muxed-destination tests for SAC transfers.
test/unit/soroban.test.ts Adds negative-amount zero-padding coverage.
test/unit/scval.test.ts Adds coverage ensuring deterministic mixed-case key ordering.
test/unit/operations/set_trustline_flags.test.ts Adds coverage for rejecting non-boolean flag values.
test/unit/operations/revoke_sponsorship.test.ts Adds coverage for signed-payload signer create + deserialize.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/transaction_builder.ts
Comment thread test/unit/transaction_builder.test.ts
Comment thread test/unit/transaction_builder.test.ts
Comment thread src/operations/revoke_sponsorship.ts
@quietbits quietbits requested a review from Ryang-21 April 1, 2026 20:45
Comment thread src/operations/types.ts

export type RevokeSignerOpts =
| Ed25519PublicKeySignerOpt
| Ed25519SignedPayloadSignerOpt

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch I assumed revoke sponsor did not apply for signed payloads

Base automatically changed from some-fixes-3 to typescript-migration April 2, 2026 19:59
@quietbits quietbits merged commit 1c96844 into typescript-migration Apr 2, 2026
7 checks passed
@quietbits quietbits deleted the some-fixes-4 branch April 2, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants