Skip to content

SPIKE: Protocol 27 — CAP-71 + CAP-83 XDR regen #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sisuresh wants to merge 4 commits into from
Closed

SPIKE: Protocol 27 — CAP-71 + CAP-83 XDR regen #972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
673fd63
SPIKE: regenerate XDR with CAP-71 + CAP-83 (Protocol 27)
sisuresh May 28, 2026
4e362da
Post-process: re-inject 'var XDR_CONST = N;' declarations
sisuresh May 28, 2026
d00b392
Replace var-decl injection with literal inlining (terser-safe)
sisuresh May 28, 2026
32709d5
Revert post-process; use the same xdrgen#152 workaround upstream mast…
sisuresh May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
XDR_BASE_URL_CURR=https://github.com/stellar/stellar-xdr/raw/cff714a5ebaaaf2dac343b3546c2df73f0b7a36e
# CAP-71 + CAP-83 pre-release: pin to the protocol-27 .x and resolve feature
# gates via `stellar-xdr xfile preprocess` (rs-stellar-xdr #503) before xdrgen,
# since the Ruby xdrgen used here does not understand #ifdef.
XDR_BASE_URL_CURR=https://github.com/stellar/stellar-xdr/raw/5187e69f568dc13ccb5ddc74f81ffd4aaba4fea1
XDR_BASE_LOCAL_CURR=xdr/curr
XDR_FEATURES=CAP_0071,CAP_0083
XDR_FILES_CURR= \
Stellar-SCP.x \
Stellar-ledger-entries.x \
Expand All @@ -15,7 +19,7 @@ XDR_FILES_CURR= \
Stellar-exporter.x
XDR_FILES_LOCAL_CURR=$(addprefix xdr/curr/,$(XDR_FILES_CURR))

XDR_BASE_URL_NEXT=https://github.com/stellar/stellar-xdr/raw/cff714a5ebaaaf2dac343b3546c2df73f0b7a36e
XDR_BASE_URL_NEXT=https://github.com/stellar/stellar-xdr/raw/5187e69f568dc13ccb5ddc74f81ffd4aaba4fea1
XDR_BASE_LOCAL_NEXT=xdr/next
XDR_FILES_NEXT= \
Stellar-SCP.x \
Expand All @@ -42,7 +46,7 @@ generate: src/generated/curr_generated.js types/curr.d.ts src/generated/next_gen
src/generated/curr_generated.js: $(XDR_FILES_LOCAL_CURR)
mkdir -p $(dir $@)
> $@
docker run -it --rm -v $$PWD:/wd -w /wd ruby:3.1 /bin/bash -c '\
docker run --rm -v $$PWD:/wd -w /wd ruby:3.1 /bin/bash -c '\
gem install specific_install -v 0.3.8 && \
gem specific_install https://github.com/stellar/xdrgen.git -b $(XDRGEN_COMMIT) && \
xdrgen --language javascript --namespace curr --output src/generated $^ \
Expand All @@ -51,15 +55,15 @@ src/generated/curr_generated.js: $(XDR_FILES_LOCAL_CURR)
src/generated/next_generated.js: $(XDR_FILES_LOCAL_NEXT)
mkdir -p $(dir $@)
> $@
docker run -it --rm -v $$PWD:/wd -w /wd ruby:3.1 /bin/bash -c '\
docker run --rm -v $$PWD:/wd -w /wd ruby:3.1 /bin/bash -c '\
gem install specific_install -v 0.3.8 && \
gem specific_install https://github.com/stellar/xdrgen.git -b $(XDRGEN_COMMIT) && \
xdrgen --language javascript --namespace next --output src/generated $^ \
'

types/curr.d.ts: src/generated/curr_generated.js
docker run -it --rm -v $$PWD:/wd -w / --entrypoint /bin/sh node:alpine -c '\
apk add --update git && \
docker run --rm -v $$PWD:/wd -w / --entrypoint /bin/sh node:lts-alpine -c '\
apk add --update git && apk add --update yarn && \
git clone --depth 1 https://github.com/stellar/dts-xdr -b $(DTSXDR_COMMIT) --single-branch && \
cd /dts-xdr && \
yarn install --network-concurrency 1 && \
Expand All @@ -69,8 +73,8 @@ types/curr.d.ts: src/generated/curr_generated.js
'

types/next.d.ts: src/generated/next_generated.js
docker run -it --rm -v $$PWD:/wd -w / --entrypoint /bin/sh node:alpine -c '\
apk add --update git && \
docker run --rm -v $$PWD:/wd -w / --entrypoint /bin/sh node:lts-alpine -c '\
apk add --update git && apk add --update yarn && \
git clone --depth 1 https://github.com/stellar/dts-xdr -b $(DTSXDR_COMMIT) --single-branch && \
cd /dts-xdr && \
yarn install --network-concurrency 1 && \
Expand All @@ -85,14 +89,17 @@ clean:
$(XDR_FILES_LOCAL_CURR):
mkdir -p $(dir $@)
curl -L -o $@ $(XDR_BASE_URL_CURR)/$(notdir $@)
stellar-xdr xfile preprocess --features "$(XDR_FEATURES)" $@ > $@.pp && mv -f $@.pp $@

$(XDR_FILES_LOCAL_NEXT):
mkdir -p $(dir $@)
curl -L -o $@ $(XDR_BASE_URL_NEXT)/$(notdir $@)
stellar-xdr xfile preprocess --features "$(XDR_FEATURES)" $@ > $@.pp && mv -f $@.pp $@

reset-xdr:
rm -f xdr/*/*.x
rm -f src/generated/*.js
rm -f types/curr.d.ts
rm -f types/next.d.ts
$(MAKE) generate

Loading
Loading