Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add socket tier 1 reachability analysis #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
add socket tier 1 reachability analysis #104
Changes from all commits
1761b31File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On every scheduled/manual scan for this crate, this pins Rust to 1.86.0 while
Cargo.tomldeclaresrust-version = "1.93.0". The Cargo Book says Cargo reports an error on unsupported toolchains, and Socket's reachability docs say the analysis needs the language build toolchain and--reach-continue-on-install-errorsfalls back to precomputed reachability, so the workflow cannot produce the intended full Cargo reachability until it installs at least 1.93.0 or the repo's configured stable toolchain.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this
socket scan createinvocation supplies only--organd there is nosocket.jsonin the repo, Socket will use its documented defaults (socket-default-repository/socket-default-branch) rather than associating the scheduled scan withrs-stellar-rpc-clientand the checked-out branch. The Socket CLI reference explicitly says--repoand--branchidentify the repository/branch for the scan, so these CI results can be filed under the generic default project instead of the dashboard entry this workflow is meant to update.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.