Embed code generators into stellar-xdr CLI

[leighmcculloch]

What

Embed the two XDR code generators into the stellar-xdr CLI as new subcommands under the existing xfile group: stellar-xdr xfile generate-rust produces src/generated.rs (and its per-type directory) and stellar-xdr xfile ast produces the JSON definitions AST. The standalone xdr-generator-rust and generator-definitions-json crates are converted from binaries into libraries exposing a generate(...) entry point, wired into the main crate as optional path dependencies enabled only by the cli feature, and the Makefile now drives generation through the CLI instead of cargo run --manifest-path.

Why

Code generation from .x files was only reachable through two binaries that live in an inner workspace, so a downstream consumer had to know about that workspace and cargo install --git … --bin … the specific generator they wanted rather than reaching for the stellar-xdr CLI they already use for the repository's other XDR tooling. Surfacing both generators as xfile subcommands puts code generation alongside the existing types, decode, encode, compare, and xfile preprocess commands under the single binary, and removes the need to expose the inner workspace to anyone who just wants to generate code.

Known limitations

Behavior is unchanged: the new subcommands and library functions reproduce the previous binaries' semantics exactly (input reading and sort-by-path, parsing, options/feature construction, and output paths), with regeneration verified to produce byte-identical src/generated.rs, src/generated/, and xdr-definitions-json/xdr.json. The only dropped behavior is the binaries' cosmetic stderr progress lines. The generators still live under xdr-generator-rust/ as libraries.

Close #527

---

Generated by Claude Code

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c93e7922b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Publish the generator crates before enabling them

When this crate is packaged for crates.io, Cargo resolves path dependencies that also specify a version from the registry rather than from the packaged subdirectory. These new optional dependencies are enabled by cli, and the existing release workflow packages the crate and then builds the packaged copy with --features cli, while the README advertises cargo install stellar-xdr --features cli; both paths will fail unless xdr-generator-rust and generator-definitions-json are published to crates.io in the right order. Please either publish/include these crates as real registry dependencies or keep the CLI generators inside the main package without registry-only path deps.

Useful? React with 👍 / 👎.

[Copilot]

Pull request overview

This PR embeds the existing XDR code generators into the stellar-xdr CLI (under xfile) by converting the generator crates from standalone binaries into libraries and wiring them as optional path dependencies behind the cli feature, so downstream users can generate Rust code and a JSON AST using the single stellar-xdr binary.

Changes:

• Convert xdr-generator-rust/generator and xdr-generator-rust/generator-definitions-json from bin crates into lib crates exposing generate(...).
• Add stellar-xdr xfile generate-rust and stellar-xdr xfile ast CLI subcommands to invoke those library entry points.
• Update the Makefile to drive generation via cargo run --features cli -- xfile ... instead of cargo run --manifest-path ....

Reviewed changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
xdr-generator-rust/generator/src/main.rs	Removes the old standalone generator CLI entry point.
xdr-generator-rust/generator/src/lib.rs	Adds library API (generate) for Rust code generation.
xdr-generator-rust/generator/Cargo.toml	Switches the generator crate from [[bin]] to [lib] and drops clap.
xdr-generator-rust/generator-definitions-json/src/lib.rs	Refactors JSON AST emitter into a library generate entry point.
xdr-generator-rust/generator-definitions-json/Cargo.toml	Switches the JSON generator crate from [[bin]] to [lib] and drops clap.
xdr-generator-rust/Cargo.lock	Updates inner workspace lockfile to reflect removal of clap and bin targets.
src/cli/xfile/mod.rs	Registers new xfile subcommands and error variants.
src/cli/xfile/generate_rust.rs	Adds CLI wrapper for Rust generator library.
src/cli/xfile/ast.rs	Adds CLI wrapper for JSON AST generator library.
Makefile	Routes generation targets through the stellar-xdr CLI subcommands.
Cargo.toml	Adds optional path deps on generator libraries and includes them in the cli feature.
Cargo.lock	Pulls generator-library dependency graph into the main lockfile under cli.

Comments suppressed due to low confidence (1)

Makefile:45

• The Makefile now uses cargo run --features cli to perform generation, which requires compiling the stellar-xdr crate first. Since stellar-xdr's library compilation depends on src/generated.rs (via mod generated;), running make clean (which deletes src/generated.rs/src/generated/) will prevent make generate from bootstrapping generation from a clean state.

Consider either (a) keeping a standalone generator binary for bootstrapping, (b) making clean stop removing src/generated.rs/src/generated/, or (c) adding a dedicated small generation-only crate/binary that doesn’t depend on the generated module but still drives generation through the same library APIs.

	cargo run --features cli -- xfile generate-rust \
		$(addprefix --input ,$(sort $(wildcard xdr/*.x))) \
		--output $@ \
		--custom-default $(CUSTOM_DEFAULT_IMPL) \
		--custom-str $(CUSTOM_STR_IMPL)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	clap@​4.6.0 ⏵ 4.6.1

View full report