Skip to content

Stub out EventV0 specs so bindings still generate - #2162

Merged
Shaptic merged 4 commits into
mainfrom
stub-eventspec
Aug 28, 2025
Merged

Shaptic merged 4 commits into
mainfrom
stub-eventspec

Conversation

@Shaptic

@Shaptic Shaptic commented Aug 28, 2025 •

Copy link
Copy Markdown
Contributor

What

Adds a stub to the EventV0 branch of ScSpecEntry.

Why

Bindings fail to generate if your wasm uses the new #[contractevent] macro, but they shouldn't:

$ stellar contract bindings typescript --output-dir testing --wasm target/wasm32v1-none/release/events.wasm 
ℹ️ Loading contract spec from file...

thread 'main' panicked at /home/george/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/soroban-spec-typescript-23.0.0/src/types.rs:255:40:
not yet implemented: EventV0 is not implemented yet

We should still let them be generated, even though there aren't bindings for the events themselves.

Known limitations

n/a, I confirmed that building this branch and running the above commands generates bindings.

@Shaptic
Shaptic requested a review from a team August 28, 2025 18:07
@Shaptic Shaptic added the bug Something isn't working label Aug 28, 2025
@github-project-automation github-project-automation Bot moved this to Backlog (Not Ready) in DevX Aug 28, 2025
@Shaptic
Shaptic enabled auto-merge (squash) August 28, 2025 19:05
@sagpatil sagpatil mentioned this pull request Aug 28, 2025
@Shaptic
Shaptic merged commit 7a08543 into main Aug 28, 2025
35 of 36 checks passed
@Shaptic
Shaptic deleted the stub-eventspec branch August 28, 2025 22:11
@github-project-automation github-project-automation Bot moved this from Backlog (Not Ready) to Done in DevX Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants