Repository navigation
Conversation
The soroban-sdk has renamed StellarAssetSpec to StellarAssetFnSpec. This fixes the compilation errors in CI where the symbol could not be found.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
- Update workspace dependencies to use soroban-sdk v23.0.0-rc.3 - Add stellar-asset-spec dependency - Replace StellarAssetFnSpec::spec_xdr() with stellar_asset_spec::xdr() - The new API uses a dedicated crate for stellar asset contract specs
sagpatil
changed the title
- Migrate hello_world and token test fixtures from deprecated events().publish() to #[contractevent] system - Update soroban-token-sdk event usage to use new event structs (Approve, TransferWithAmountOnly, Burn, MintWithAmountOnly) - Fix token Interface implementation to use MuxedAddress for transfer parameter - Add custom SetAdmin event struct for token admin changes This resolves CI build failures on Windows, macOS, and Linux caused by deprecated API warnings being treated as errors.
- Format imports in hello_world fixture (split long line) - Format imports and event publish calls in token fixture - Ensure consistent formatting according to rustfmt standards
Update hello_world integration test to expect the new contractevent format:
- Old: Event: [{"symbol":"hello"},{"symbol":""}] = {"symbol":"world"}
- New: Event: [{"symbol":"hello_event"}] = {"map":[{"key":{"symbol":"str"},"val":{"symbol":"world"}}]}
This aligns the test with the updated hello_world fixture that uses the new #[contractevent] system.
sagpatil
changed the title
- Add Event variant to Entry enum for proper EventV0 handling - Replace todo! macro with proper EventV0 processing - Fixes cookbook integration test failures caused by rs-soroban-sdk v23.0.0-rc.3 upgrade - Resolves panic when processing contracts with #[contractevent] attributes
- Fix transfer command to use correct --from --to --amount argument order - Matches the working syntax used in asset-management.mdx - Resolves cookbook test failure for stellar asset contract operations
sagpatil
commented
Aug 29, 2025
| - Video Tutorial on `network container`, `keys`, and `contract init`: https://developers.stellar.org/meetings/2024/06/27 | ||
| - Video Tutorial on `alias` and `snapshot`: https://developers.stellar.org/meetings/2024/09/12 | ||
|
|
||
| <!-- CI system test comment --> |
Contributor
Author
There was a problem hiding this comment.
need to remove this
sagpatil
requested review from
leighmcculloch
and removed request for
leighmcculloch
August 29, 2025 07:24
- Handle both Address and MuxedAddress types in argument parsing - Resolve address aliases and extract signers for both types - Fixes cookbook test failures with MuxedAddress arguments
sagpatil
changed the title
Contributor
|
Claude is attempting to add parsing of MuxedAddress in cmd/crates/soroban-spec-tools/src/lib.rs in my PR. You might need that here. |
Contributor
Author
|
closing this in favor of #2173 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: add comment to trigger CI system test