Skip to content

Fix openzeppelin and soroban-examples tests for v28 #2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fnando merged 1 commit into from
Sep 28, 2026
Merged

Fix openzeppelin and soroban-examples tests for v28 #2761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions .github/workflows/test-with-openzeppelin-contracts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ jobs:
fail-fast: false
matrix:
dir: ${{ fromJSON(needs.collect-crates.outputs.dirs) }}
experimental_spec_shaking_v2: [true, false]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v7
Expand All @@ -66,16 +65,6 @@ jobs:
- run: echo "${{ github.workspace }}/stellar-cli" >> $GITHUB_PATH
- run: rustup update
- run: rustup target add wasm32v1-none
- name: Enable experimental_spec_shaking_v2 feature
if: matrix.experimental_spec_shaking_v2
run: |
find . -name Cargo.toml | while read -r file; do
# Add feature to entries with existing features
sed -i '/soroban-sdk = {/s|features = \[|features = ["experimental_spec_shaking_v2", |' "$file"
# Add features field to entries without features
sed -i '/soroban-sdk = {/{/features/!s| }|, features = ["experimental_spec_shaking_v2"] }|}' "$file"
done
cargo update -p soroban-sdk
- name: Diff
run: git diff
- name: Build ${{ matrix.dir }}
Expand All @@ -88,7 +77,7 @@ jobs:
echo "wasm=$wasm" | tee -a $GITHUB_OUTPUT
- name: Set artifact name
id: artifact-name
run: echo "name=wasm-$(echo ${{ matrix.dir }} | sed 's/\//-/g')${{ matrix.experimental_spec_shaking_v2 && '-spec-shaking-v2' || '' }}" | tee -a $GITHUB_OUTPUT
run: echo "name=wasm-$(echo ${{ matrix.dir }} | sed 's/\//-/g')" | tee -a $GITHUB_OUTPUT
- name: Upload WASM artifacts
uses: actions/upload-artifact@v7.0.1
with:
Expand Down
13 changes: 1 addition & 12 deletions .github/workflows/test-with-soroban-examples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ jobs:
fail-fast: false
matrix:
dir: ${{ fromJSON(needs.collect-examples.outputs.dirs) }}
experimental_spec_shaking_v2: [true, false]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v7
Expand All @@ -74,16 +73,6 @@ jobs:
- run: echo "${{ github.workspace }}/stellar-cli" >> $GITHUB_PATH
- run: rustup update
- run: rustup target add wasm32v1-none
- name: Enable experimental_spec_shaking_v2 feature
if: matrix.experimental_spec_shaking_v2
run: |
find . -name Cargo.toml | while read -r file; do
# Add feature to entries with existing features
sed -i '/soroban-sdk = {/s|features = \[|features = ["experimental_spec_shaking_v2", |' "$file"
# Add features field to entries without features
sed -i '/soroban-sdk = {/{/features/!s| }|, features = ["experimental_spec_shaking_v2"] }|}' "$file"
(cd "$(dirname "$file")" && cargo update -p soroban-sdk 2>/dev/null || true)
done
- name: Diff
run: git diff
- name: Build ${{ matrix.dir }}
Expand All @@ -96,7 +85,7 @@ jobs:
echo "wasm=$wasm" | tee -a $GITHUB_OUTPUT
- name: Set artifact name
id: artifact-name
run: echo "name=wasm-$(echo ${{ matrix.dir }} | sed 's/\//-/g')${{ matrix.experimental_spec_shaking_v2 && '-spec-shaking-v2' || '' }}" | tee -a $GITHUB_OUTPUT
run: echo "name=wasm-$(echo ${{ matrix.dir }} | sed 's/\//-/g')" | tee -a $GITHUB_OUTPUT
- name: Upload WASM artifacts
uses: actions/upload-artifact@v7.0.1
with:
Expand Down
Loading