SPIKE: Protocol 28 (CAP-0084)#199
Closed
sisuresh wants to merge 1 commit into
Closed
Conversation
…int destinations Re-pin go-stellar-sdk to the CAP-0084 fork head (sisuresh/go@094cee38), which adds the muxed-contract XDR arm and a destination_muxed_id field on the contract_credited effect resource. Drop the interim ScAddressType placeholder in contractevents and surface destination_muxed_id on contract_credited effects for muxed-contract destinations (mirroring SAC balance-change handling). destination_muxed_id is a decimal string (mirroring operations.AssetContractBalanceChange.DestinationMuxedId) so a mux id of 0 round-trips through details -> SDK struct -> API JSON. Upstream: stellar/go-stellar-sdk via sisuresh/go#1. Deferred only if local core build blocks: TestCoreLCMIngestion muxed-contract fixture (capture via local stellar-core#17 --capture-lcm).
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
sisuresh/go@094cee38): adds the muxed-contract XDR arm +destination_muxed_idon thecontract_creditedeffect resource.ScAddressTypeplaceholder incontractevents;ScAddress.String()now renders the muxed-contract arm directly.destination_muxed_idoncontract_creditedeffects for muxed-contract transfer/mint destinations (mirrorsoperations_processorSAC balance-change handling).0round-trip.Review notes
destination_muxed_idrepresentation needs human review. It's astring(mirroringoperations.AssetContractBalanceChange.DestinationMuxedId) specifically so a mux id of0round-tripsdetails → SDK struct → API JSON;uint64+,string+omitemptywould silently drop"0". No canonical muxed-contract strkey exists upstream yet, so the raw id is surfaced.Deferred
TestCoreLCMIngestionmuxed-contract dir): local core binary isv27.0.0-28-g930fa0226— the parent of CAP-0084fc0a370d— with emptysoroban-env-host; needs a CAP-0084 stellar-core build + C++-test LCM dump. Unit/resource tests are the real correctness gate.PROTOCOL_28_CORE_DOCKER_IMG/PROTOCOL_28_CORE_DEBIAN_PKG_VERSIONto afc0a370dbuild — not yet published (newest vnext is6e768de7a/3369). The P28 leg otherwise runs a host that can't exercise CAP-0084.Upstream
effects.ContractCreditedfield). One CI shard is red on a flaky, unrelatedingest.TestBSBProducerFnCallbackError; a parallel run at the same head is fully green.fc0a370d)