Add support for measuring tx e2e latency - #417
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds configurable load-generator nodes and gated transaction end-to-end latency metrics for pubnet performance missions.
Changes:
- Selects load generators from a public-key file.
- Enables and logs e2e latency metrics only for selected generators.
- Adds an e2e measurement preset and expands the SLP evaluation wrapper.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/FSLibrary/StellarNetworkData.fs |
Maps loadgen keys to dedicated core sets. |
src/FSLibrary/StellarMissionContext.fs |
Adds measurement and loadgen settings. |
src/FSLibrary/StellarCoreSet.fs |
Marks load-generating core sets. |
src/FSLibrary/StellarCoreCfg.fs |
Gates the stellar-core latency metric. |
src/FSLibrary/MinBlockTimeTest.fs |
Selects generators and logs latency metrics. |
src/FSLibrary/MaxTPSTest.fs |
Uses configured load generators. |
src/FSLibrary/json-type-samples/sample-metrics.json |
Defines latency metric shapes. |
src/FSLibrary.Tests/Tests.fs |
Updates the test mission context. |
src/App/Program.fs |
Adds and validates CLI options. |
scripts/slp_eval.sh |
Supports topology overrides and forwarded arguments. |
scripts/measure_e2e.sh |
Adds the e2e measurement preset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marta-lokhova
left a comment
marta-lokhova
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM, though I think it'd be good to merge once p28 and CI stabilize, and avoid introducing new (potentially unstable) changes. Let's merge after the release is done, so likely next week!
marta-lokhova
approved these changes
Aug 13, 2026
marta-lokhova
left a comment
marta-lokhova
left a comment
Contributor
There was a problem hiding this comment.
can address copilot feedback in a follow-up to unstick this PR!
marta-lokhova
approved these changes
Aug 14, 2026
drebelsky
force-pushed
the
set-load-generators
branch
from
August 14, 2026 00:08
c64c3fa to
31adefd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated version of #394, trimmed down to just the changes needed for our e2e measurements.