Refactor/major deps upgrade (with SWK v2.x) - #44
Draft
aolieman wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're stuck on some pretty old package versions. Upgrading to all latest majors confronts us with a ton of breaking changes.
I have dealt with a lot of those changes already. The most challenging is the upgrade to Stellar Wallets Kit v2.x. It has become very pushy about using the batteries-included auth modal and other UI elements. We have our fully custom UI and these conflict easily.
To get unstuck, we may need to migrate the wallet connect UI to an SWK theme. I am reluctant to make that decision. Today's draft includes a workaround that prevents hydration errors, but still has incomplete wallet connection logic. Continuing this approach will probably gives the fastest result, but it feels like a temporary solution.
The more robust solution to keep our custom UI, would be to make a "headless" config possible in SWK itself — an opt-out for all DOM mutations. This is not trivial to do in a backwards-compatible way, because the theme style is currently applied to the document container at import time.