Skip to content

fix(SSR): drop use client from components.server.ts #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mpesic wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(SSR): drop use client from components.server.ts #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions example-project/component-library-react/src/components.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
'use client';

/**
* This file was automatically generated by the Stencil React Output Target.
* Changes to this file may cause incorrect behavior and will be lost if the code is regenerated.
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/create-stencil-react-components.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ describe('createStencilReactComponents', () => {
clientModule: './client',
});

expect(result).toContain(`'use client';`);
expect(result).not.toContain(`'use client';`);
expect(result).toContain(`// @ts-ignore - ignore potential type issues as the project is importing itself`);
expect(result).toContain(`import * as clientComponents from "./client";`);
expect(result).toContain(`from '@stencil/react-output-target/ssr'`);
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/create-stencil-react-components.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const createStencilReactComponents = ({
* automatically attach the `use client` directive if we are not generating
* server side rendering components.
*/
const useClientDirective = `'use client';\n\n`;
const useClientDirective = hydrateModule ? '' : `'use client';\n\n`;
const autogeneratedComment = `/**
* This file was automatically generated by the Stencil React Output Target.
* Changes to this file may cause incorrect behavior and will be lost if the code is regenerated.
Expand Down
Loading