Repository navigation
chore: sync with upstream v0.33.0 - #103
Conversation
|
📦 Target Release Version: |
PR ReviewAction TypeDocker-based action — uses a pre-built Docker image published to ✅ Passed Checks
❌ Failed Checks
|
| <<<<<<< c91b7c102591cac31fa35dbb9dfd6ab31da5e4fa | ||
| FROM golang:1.27-alpine3.24@sha256:8a5910f31396cd4d89662f56c68b3ae31d374308270a1c3bd96672ee5ed43414 AS go-builder | ||
| ======= | ||
| FROM node:24-bookworm-slim@sha256:55fb5f5a527ea2c5c4a95f963e48ef90aa38c7b346054fdc8ee9957a2b55d205 | ||
|
|
||
| ENV REVIEWDOG_VERSION=v0.21.2 | ||
| ENV MARKDOWNLINT_CLI_VERSION=v0.50.0 | ||
|
|
||
| RUN npm install -g "markdownlint-cli@$MARKDOWNLINT_CLI_VERSION" | ||
| >>>>>>> e82b781e8865cb734917fdfb8157d49d91271775 |
There was a problem hiding this comment.
❌ Unresolved merge conflict — this Dockerfile cannot be built.
Lines 1–9 contain raw Git conflict markers (<<<<<<<, =======, >>>>>>>). The conflict is between:
- HEAD (this repo's base): Multi-stage build using
golang:1.27-alpine3.24as a Go builder to compilereviewdogfrom source. - Upstream (v0.33.0): Single-stage build using
node:24-bookworm-slimwithmarkdownlint-cli@v0.50.0pre-installed via npm.
The conflict must be resolved before this PR can be merged. The resolution strategy should be discussed: either keep the multi-stage Go build (and update the Node runtime stage) or adopt the upstream's simpler single-stage approach. The existing multi-stage Dockerfile already handles the Node runtime in the second FROM block (line 20 onward), so the upstream's new single-stage block would likely need to be integrated differently.
| # Do not edit by hand; run `gh actions-lock` to update. | ||
| # Docs: https://gh.io/actions-lockfile | ||
| version: 'v0.0.3' | ||
| workflows: |
There was a problem hiding this comment.
This actions.lock file was cherry-picked from upstream (reviewdog/action-markdownlint) but it references workflows that do not exist in this repository:
.github/workflows/depup.yml— not present here.github/workflows/dockerimage.yml— not present here.github/workflows/release.yml— not present here
Only .github/workflows/reviewdog.yml exists in this repo. This lock file reflects upstream's workflow structure, not ours. It should either be removed or regenerated against this repository's actual workflows using gh actions-lock.
| FROM golang:1.27-alpine3.24@sha256:8a5910f31396cd4d89662f56c68b3ae31d374308270a1c3bd96672ee5ed43414 AS go-builder | ||
|
|
||
| ENV REVIEWDOG_VERSION=v0.21.2 | ||
| ENV REVIEWDOG_VERSION=v0.21.3 |
There was a problem hiding this comment.
reviewdog is cloned from GitHub at build time using git clone --branch ${REVIEWDOG_VERSION}. This means the Docker image build is dependent on GitHub's availability at build time. Consider whether pinning by tag is sufficient here or if a digest-pinned approach is preferred for more reproducible builds.
|
PR Review posted as inline comments. See inline review comments on the diff for specific findings. Summary: Docker-based action. Version bumps correct. Failed: README uses full semver not major version, action.yml not updated to v0.33.0, Docker image uses full semver tag not major, actions.lock cherry-picked from upstream references non-existent workflows. No critical security issues. |
|
FULL REVIEW - Action Type: Docker-based. PASSED: License OK (prologic + StepSecurity), action.yml author=step-security, SECURITY.md present, no FUNDING.yml, auto_cherry_pick.yml + actions_release.yml present, no renovate.json/PULL_REQUEST.md/ISSUE_TEMPLATE/CHANGELOG.md/.vscode, README banner present, subscription check URL correct, UPSTREAM var matches auto_cherry_pick.yml, image on GHCR step-security org. FAILED: (1) README example uses commit SHA with v0.26.2 semver comment - must use @v0 only; (2) action.yml image uses full semver :v0.31.2 - must use major version tag :v0; (3) action.yml not updated from v0.31.2 to v0.33.0 to match this sync; (4) actions.lock cherry-picked from upstream references depup.yml, dockerimage.yml, release.yml which do not exist here. WARNINGS: unquoted INPUT_MARKDOWNLINT_FLAGS/REVIEWDOG_FLAGS (intentional, accepted risk); echo -e with /bin/sh (harmless on Alpine). SECURITY: no critical findings; subscription check correct; minor - reviewdog git clone pinned by tag not digest. SUMMARY: version bumps correct but action.yml, README, and actions.lock need attention before merge. |
| "action_type": "docker", | ||
| "upstream": { | ||
| "repository": "reviewdog/action-markdownlint", | ||
| "synced_tag": "v0.33.0", |
There was a problem hiding this comment.
The synced_tag here is v0.33.0, but action.yml still references the old Docker image tagged v0.31.2. After merging this PR, the Docker image for v0.33.0 must be built and pushed, and then action.yml updated to reference the new image SHA/tag. As-is, users of this action will still run the v0.31.2 Docker image even though the Dockerfile has been updated.
| FROM golang:1.27-alpine3.24@sha256:8a5910f31396cd4d89662f56c68b3ae31d374308270a1c3bd96672ee5ed43414 AS go-builder | ||
|
|
||
| ENV REVIEWDOG_VERSION=v0.21.2 | ||
| ENV REVIEWDOG_VERSION=v0.21.3 |
There was a problem hiding this comment.
The reviewdog build clones GitHub using a git tag (--branch ${REVIEWDOG_VERSION}). Git tags are mutable — a tag can be moved to a different commit after the fact. For a stronger supply chain guarantee, consider pinning to a commit SHA instead (e.g., --branch <sha>). The Go module pin (golang.org/x/crypto@v0.45.0) is a good pattern — the same approach at the source level would eliminate this remaining risk.
PR ReviewAction TypeDocker-based action - runs a pre-built Docker image referenced in action.yml, built from the Dockerfile in this repo. Passed Checks
Failed Checks
Warnings
Security Findings
SummaryThis PR correctly bumps REVIEWDOG_VERSION (v0.21.2 to v0.21.3) and MARKDOWNLINT_CLI_VERSION (v0.49.1 to v0.50.0) in the Dockerfile and adds a config.json sync-tracking file, but the PR is incomplete: action.yml still points to the old v0.31.2 Docker image and must be updated after the new image is built and pushed. Additionally, the Docker publish workflow should be updated to push a major-version tag alongside the full semver tag. |
reviewdog/action-markdownlint@v0.31.2...v0.33.0