-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- use newer version of semver -- old version was sorting lexically instead of numerically Refactor version comparison, check errors, maintain logic summary of diff --git a/v3/core/api.go b/v3/core/api.go - Extract version comparison operation into a separate line to obtain result and error - Check for errors after comparing versions with semver.Cmp - Keep existing logic to append paths based on version comparison results Enhance commit to allow custom git diff arguments summary of diff --git a/v3/core/cli.go b/v3/core/cli.go - Add `Diffargs` field to `cmdCommit` struct to allow passing of custom arguments to `git diff` - Modify `commitMessage` function to accept variable arguments for `git diff` - Set default `git diff` arguments to `--staged` if no arguments provided by user - Update `Cli` function to handle `commit` command with customizable `git diff` arguments - Ensure `commit` and `commit <diffargs>` commands fall through to the same case, enabling argument passing Update Tassert error message to include stdout and stderr summary of diff --git a/v3/core/cli_test.go b/v3/core/cli_test.go - Update the error message in `Tassert` to include `stdout` and `stderr` information for better debugging insight Ensure CLI output matches expectations with stdout.String() summary of diff --git ") - Assert that the CLI returns the expected output based on stdout.String() Update version in grokker.go from 3.0.10 to 3.0.11 summary of diff --git a/v3/core/grokker.go b/v3/core/grokker.go - Update version from 3.0.10 to 3.0.11 in grokker.go Refactor semver checks and error handling in migrate.go summary of diff --git a/v3/core/migrate.go b/v3/core/migrate.go - Extract comparison of `dbver` and `codever` into a separate variable `cmp` to avoid calling `semver.Cmp()` twice - Check for errors immediately after calling `semver.Cmp()` - Update the check for database version newer than code to use the `cmp` variable - Expand the call to `semver.Upgrade()` to include an error check and adapt it to an updated function signature that returns four values instead of three Prefix ./ to grok in TestMigration_2_1_2; add TestMigration_3_0_10 test. summary of diff --git a/v3/core/migration_test.go b/v3/core/migration_test.go - Prefix "./" to the "grok" command in the calls within `TestMigration_2_1_2` test function to ensure correct executable path - Introduce a new test function `TestMigration_3_0_10` to verify integer ordering works as expected across upgrades - In `TestMigration_3_0_10`, add steps to build "grok" for versions "v3.0.9" and "v3.0.10" and execute "ls" command to trigger version upgrade process Update go-openai, relocate stevegt/semver with new version summary of diff --git a/v3/go.mod b/v3/go.mod - Update github.com/sashabaranov/go-openai from v1.9.0 to v1.19.1 - Remove github.com/stevegt/semver version 92220054a49f from the first require block - Add github.com/stevegt/semver version 5913d1a31c26 to the second require block Update stevegt/semver to new version, replace hashes summary of diff --git a/v3/go.sum b/v3/go.sum - Update github.com/stevegt/semver to version v0.0.0-20240217000820-5913d1a31c26 - Replace previous hashes for github.com/stevegt/semver with new ones reflecting the update
- Loading branch information
Showing
8 changed files
with
42 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters