Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap support in hwacc #11

Open
wants to merge 7 commits into
base: ged-dev
Choose a base branch
from
Open

Tap support in hwacc #11

wants to merge 7 commits into from

Conversation

Kuree
Copy link
Contributor

@Kuree Kuree commented Jun 24, 2018

This PR adds tap stencil support in hwacc driver, tested with Halide-HLS codegen. Various improvements:

  1. Add indexing in device tree overlay so that the driver will automatically arrange the channel orders to match with the pipeline_zynq call.
  2. Use UBuffer to wrapper around tap values without resorting to cmabuffer. The user memory is set with UBuffer's id and stride (high and low), as these two values are meaningless in 1D tap values. If the height is set to 1, which is done automatically through f4graph+Halide, the driver will treat the UBuffer as tap values.
    • No extra changes needed in f4graph, which is an advantage of using tap values with Zynq CodeGen.
    • The only limitation is that only 1D taps are supported. However, if we have 2D taps, then we might as well just use 2D streaming interface (as an image).

Tested with seedark_hw in f4graph.

Need some sleep...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants