Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tap stencil support in
hwacc
driver, tested withHalide-HLS
codegen. Various improvements:pipeline_zynq
call.UBuffer
to wrapper around tap values without resorting tocmabuffer
. The user memory is set withUBuffer
'sid
andstride
(high and low), as these two values are meaningless in 1D tap values. If theheight
is set to 1, which is done automatically through f4graph+Halide, the driver will treat theUBuffer
as tap values.f4graph
, which is an advantage of using tap values with Zynq CodeGen.Tested with
seedark_hw
inf4graph
.Need some sleep...