Fix a bug when depth==1 #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's actually a similar problem I found a few days ago - suppose the input depth is 2 (1 16-bit pixel per cycle) and the output depth is 3 (1 24-bit RGB pixel per cycle). If we downconvert the output to 2 bytes/cycle, we end up stalling the pipeline for 1/3 of the cycles, which is really bad. A better algorithm would be to find the next power of 2 greater or equal to the output size, and convert to that. We can fix that separately, or just roll it into this PR. |
|
Can we go ahead and change this to use the next larger power of 2 when the width doesn't match? It looks like this just requires changing the |
|
I will do that once I finish the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hls depth is 1, using 16-bit data width converter to upscale causes problems, as we observed yesterday. This PR removes data width converter and set dma width to 1, which allows the
hwacctest to run successfully.My guess to the bug is that when the data size streamed in is not an even number, upscaling from 1 to 2 has some padding issue.
Tested applications with depth==1 and depth ==3.