Skip to content

get client id and secret from parameter store - #244

Open
MrC1rcle wants to merge 6 commits into
mainfrom
newlogin
Open

get client id and secret from parameter store#244
MrC1rcle wants to merge 6 commits into
mainfrom
newlogin

Conversation

@MrC1rcle

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread terraform/variables.tf Outdated
Comment thread terraform/main/variables.tf Outdated
@stevensnicholas

Copy link
Copy Markdown
Owner

Github action deployment is going to have to be altered to allow this as there are new variables needed to be inputed.

@MrC1rcle

Copy link
Copy Markdown
Collaborator Author

Github action deployment is going to have to be altered to allow this as there are new variables needed to be inputed.

is that a trouble or some huge change on current code? we can also just store that in the parameter store manually as only one day left

@stevensnicholas

stevensnicholas commented Aug 10, 2022

Copy link
Copy Markdown
Owner

OK I'v altered the deploy action so it will pull the repo secrets GIT_HUB_CLIENT_ID and GIT_HUB_CLIENT_SECRET and input it into the terraform

@MrC1rcle

Copy link
Copy Markdown
Collaborator Author

cool

Comment thread terraform/main/rsakey.tf Outdated
}

resource "aws_ssm_parameter" "client_id" {
name = "client_id"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need the deployment id for all of these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants