fix(config): normalize keys in GetYamlConfig to match SetYamlConfig #874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GetYamlConfigwas not normalizing key aliases (e.g.,sync.branch→sync-branch), causingbd config get sync.branchto return "not set" even when the value was correctly stored.SetYamlConfigalready normalized keys, butGetYamlConfigdid not, leading to a confusing mismatch where set appeared to work but get could not find the value.Reproduction
Fix
Added key normalization to
GetYamlConfigto matchSetYamlConfig:Test Plan
TestGetYamlConfig_KeyNormalization- verifies aliased key lookup worksTestNormalizeYamlKeystill passesTestSetYamlConfig_KeyNormalizationstill passes./internal/config/...tests passFixes #873