fix(mcp): use os.homedir() instead of literal '~' fallback #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
path.join() doesn't expand tilde, so when process.env.HOME is undefined,
the fallback to
'~'created literal directories named'~/'instead ofexpanding to the user's home.
This caused the proliferation of confusing '~/' directories containing
.efrit/logs/. It's also kind of terrifying to try and remove.
Fix
osmoduleos.homedir()as fallback instead of literal'~'stringBefore
After