Make ProcessMessages synchronous now that it no longer awaits#177
Merged
Conversation
The dedup branch no longer awaits _messageClearer.Clear (it stages the position and persists it to the DeliveredPositionsId effect instead), so ProcessMessages has no remaining awaits. Change it from async Task to void and drop the await at both call sites (Push, FetchAndNotify). Both callers remain async for the fetch semaphore and message-store calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #176. The dedup branch in
QueueManager.ProcessMessagesno longer awaits_messageClearer.Clear— it stages the position and persists it to theDeliveredPositionsIdeffect instead — soProcessMessageshas no remainingawaits.This changes it from
async Tasktovoidand drops theawaitat both call sites (Push,FetchAndNotify). Both callers remainasyncfor the fetch-semaphore wait and the message-store call.Notes
The "make synchronous" cleanup was originally meant to ride along on #176 but was dropped when that PR squash-merged before its second commit synced. This PR redoes it on top of current
main.Testing
dotnet buildof the core project passes (0 warnings, 0 errors) — confirms no "async method lacks await" warnings, i.e. both callers genuinely still need to be async.