Fixes some TES submissions issues #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claymcleod
force-pushed
the
main
branch
2 times, most recently
from
9c5f81a to
b5ab5d1
Compare
claymcleod
reviewed
Jan 29, 2025
claymcleod
reviewed
Jan 29, 2025
|
I also opened this as part of this investigation: ohsu-comp-bio/funnel#1138. |
|
@vsmalladi I think this should have you handled. Please give all of the examples a shot one more time to make sure I haven't re-broken anything. |
|
@claymcleod looks great. I think you can merge. |
claymcleod
force-pushed
the
main
branch
2 times, most recently
from
9db3ed2 to
4e1d709
Compare
This commit is comprised of the following commits. * Fix Basic authentication (by @vsmalladi). Closes stjude-rust-labs#3. * Add in option to no remove null values from payload (by @vsmalladi). Closes stjude-rust-labs#2. * Fix url parsing issue with endpoint not keeping url after url (by @vsmalladi). Closes stjude-rust-labs#1. * chore: `cargo fmt` * revise: don't require basic auth for examples * revise: reverts `base_url` conversion to string * revise: fixes the behavior of `outputs` on a task log * fix: ensures base url always has a trailing slash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1
Closes #2
Closes #3