Skip to content

[PYBStick] Add Sx pin number naming Eg. S3 (pin 3) = D0 (arduino) = PB9 (stm32 mcu) #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2020

Conversation

garatronic
Copy link

Ajout nominations port par numéro de broches Sx. Eg. S3 (broche 3) = D0 (arduino) = PB9 (port micro stm32) pour garder la cohérence avec l'utilisation de la carte sous Micropython.

Merci d'avance.

@fpistm fpistm self-requested a review May 14, 2020 12:50
@fpistm fpistm added the enhancement New feature or request label May 14, 2020
@fpistm fpistm added this to the 1.9.0 milestone May 14, 2020
@fpistm
Copy link
Member

fpistm commented May 14, 2020

Thanks @garatronic

Could you update your commit message and avoid french usage.
https://github.com/stm32duino/Arduino_Core_STM32/blob/master/CONTRIBUTING.md#4-commit-messages

Ex:

[PYBStick]  Add Sx pin number naming

Eg. S3 (pin 3) = D0 (arduino) = PB9 (stm32 mcu)

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM anyway please update the commit message as described in my previous comment.

@garatronic garatronic changed the title Add Sx pin number naming. Eg. S3 (pin 3) = D0 (arduino) = PB9 (stm32 … [PYBStick] Add Sx pin number naming Eg. S3 (pin 3) = D0 (arduino) = PB9 (stm32 mcu) May 14, 2020
@garatronic
Copy link
Author

I think i dit it but ...

@fpistm
Copy link
Member

fpistm commented May 14, 2020

git commit --amend -m "New and correct message"

git commit --amend -m '[PYBStick] Add Sx pin number naming

Eg. S3 (pin 3) = D0 (arduino) = PB9 (stm32 mcu)'

Eg. S3 (pin 3) = D0 (arduino) = PB9 (stm32 mcu)
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm merged commit 96e597c into stm32duino:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants