-
Notifications
You must be signed in to change notification settings - Fork 1.1k
ST USB Middleware: Line endings changed to LF, partial code formatting #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
In fact, I avoid to change the code provided with the Cube FW package. This ease to track real diff btw version. About changing the file format to unified source is something I've made also. Anyway, I guess you could save time using directly AStyle? |
|
At this moment I'm working on this code, speeding up the USB. (and yes, i have to change this USB middleware and also pcd and ll_usb from HAL - it all contains a lot of errors). And these formatting bugs annoy me: double spaces, curved alignment, this code looks like, it was written in a hurry by the drunk man... |
|
Don't know who has written this code, but agreed the code formatting is not "good". |
|
I would be very happy if you create some styleset for the repository. So that anybody can automaticaly format the code before commit. And I have a question: can we influence the original source libraries? I was not kidding about the errors in the HAL. For example, data is copied to PMA twice (the second copy is redundant) on the STM32F103 every time when it sent to the host. |
|
Of course, each issue found in HAL or middleware are raised internally for correction. |
|
Perfect |
|
About style, i've already manage this: |
|
@makarenya is this one deprecated and replaced by #453? |
|
yes |
USB Device Middleware:
Ling endings changed to LF (it's common for all other parts of this repository)
And couple of files have been processed through clang-format and formatted by hands.