Skip to content

Add networkPolicies.enabled and olmVersion to chart values - #3695

Merged
openshift-merge-bot[bot] merged 1 commit into
stolostron:mainfrom
dislbenn:add-chart-values-fields
Jul 22, 2026
Merged

Add networkPolicies.enabled and olmVersion to chart values#3695
openshift-merge-bot[bot] merged 1 commit into
stolostron:mainfrom
dislbenn:add-chart-values-fields

Conversation

@dislbenn

Copy link
Copy Markdown
Collaborator

Summary

  • Add global.networkPolicies.enabled: true to all toggle chart values.yaml files (was missing from fleet-navigation)
  • Add global.olmVersion: v0 to all toggle chart values.yaml files
  • Add both fields to hack/bundle-automation/chart-templates/values.yaml so automated chart regeneration preserves them

Test plan

  • Run make regenerate-charts and verify generated values.yaml files retain both fields
  • Verify NetworkPolicy templates render correctly with networkPolicies.enabled: true
  • Verify no regressions in chart rendering

🤖 Generated with Claude Code

Add global.networkPolicies.enabled: true and global.olmVersion: v0 to
all toggle chart values.yaml files and the chart-templates default so
chart regeneration preserves these fields.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: dislbenn <dbennett@redhat.com>
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@dislbenn, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository: stolostron/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 90d947fd-d51b-4d2d-a59c-399b6ded122b

📥 Commits

Reviewing files that changed from the base of the PR and between 57aa0f0 and c1ab652.

📒 Files selected for processing (24)
  • hack/bundle-automation/chart-templates/values.yaml
  • pkg/templates/charts/toggle/assisted-service/values.yaml
  • pkg/templates/charts/toggle/cluster-api-k8s/values.yaml
  • pkg/templates/charts/toggle/cluster-api-provider-aws/values.yaml
  • pkg/templates/charts/toggle/cluster-api-provider-azure-k8s/values.yaml
  • pkg/templates/charts/toggle/cluster-api-provider-azure/values.yaml
  • pkg/templates/charts/toggle/cluster-api-provider-metal3-k8s/values.yaml
  • pkg/templates/charts/toggle/cluster-api-provider-metal3/values.yaml
  • pkg/templates/charts/toggle/cluster-api-provider-openshift-assisted-k8s/values.yaml
  • pkg/templates/charts/toggle/cluster-api-provider-openshift-assisted/values.yaml
  • pkg/templates/charts/toggle/cluster-api/values.yaml
  • pkg/templates/charts/toggle/cluster-lifecycle/values.yaml
  • pkg/templates/charts/toggle/cluster-manager/values.yaml
  • pkg/templates/charts/toggle/cluster-permission/values.yaml
  • pkg/templates/charts/toggle/cluster-proxy-addon/values.yaml
  • pkg/templates/charts/toggle/console-mce/values.yaml
  • pkg/templates/charts/toggle/discovery-operator/values.yaml
  • pkg/templates/charts/toggle/fleet-navigation/values.yaml
  • pkg/templates/charts/toggle/hive-operator/values.yaml
  • pkg/templates/charts/toggle/hypershift/values.yaml
  • pkg/templates/charts/toggle/image-based-install-operator/values.yaml
  • pkg/templates/charts/toggle/maestro/values.yaml
  • pkg/templates/charts/toggle/managed-serviceaccount/values.yaml
  • pkg/templates/charts/toggle/server-foundation/values.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@cameronmwall

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cameronmwall, dislbenn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cameronmwall,dislbenn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit a8d06ab into stolostron:main Jul 22, 2026
13 checks passed
kurwang pushed a commit to kurwang/backplane-operator that referenced this pull request Jul 27, 2026
…olostron#3695)

Add global.networkPolicies.enabled: true and global.olmVersion: v0 to
all toggle chart values.yaml files and the chart-templates default so
chart regeneration preserves these fields.

Signed-off-by: dislbenn <dbennett@redhat.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants