fix: add NetworkPolicy to optional supported bundle resource types - #167
Conversation
NetworkPolicy was present in resource_kinds (for template processing) but missing from optional_supported_bundle_resourceTypes (for copying from bundle/manifests/). This caused NetworkPolicy resources in OLM bundles to be rejected as unsupported during the copy step. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dislbenn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: stolostron/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe optional bundle resource allowlist now includes the Kubernetes ChangesBundle resource support
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Add
NetworkPolicytooptional_supported_bundle_resourceTypesso that NetworkPolicy resources in OLM bundle manifests are correctly copied into Helm chart templates during chart generation.Related Issue
Follow-up to #164 and #165 which added NetworkPolicy helm conditional wrapping to chart generation.
Changes Made
NetworkPolicyto theoptional_supported_bundle_resourceTypeslist inbundles-to-charts.pyNetworkPolicywas already present inresource_kinds(used for template processing/wrapping) but was missing from the bundle copy allowlist, causing NetworkPolicy resources inbundle/manifests/to be rejected as "unsupported" during the copy stepScreenshots (if applicable)
N/A
Checklist
Additional Notes
Without this fix, any component that ships a NetworkPolicy in its OLM bundle manifests would have that resource silently dropped during chart generation — the copy step would log it as "Unsupported resource type" and skip it, even though the downstream template processing step (
resource_kinds) already knows how to handle and wrap NetworkPolicy resources.Reviewers
Definition of Done
Summary by CodeRabbit
NetworkPolicyresources as optional bundle artifacts.