Skip to content

a non subscription-admin should not deploy cluster-scoped resources b… - #1710

Merged
xiangjingli merged 1 commit into
release-2.15from
cherry-pick-1703-1704-release-2.15
Aug 18, 2026
Merged

a non subscription-admin should not deploy cluster-scoped resources b…#1710
xiangjingli merged 1 commit into
release-2.15from
cherry-pick-1703-1704-release-2.15

Conversation

@xiangjingli

@xiangjingli xiangjingli commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

…y default (#1703, #1704)

Cherry-pick of:

  • I have taken backward compatibility into consideration.

https://redhat.atlassian.net/browse/ACM-39827

…y default (#1703, #1704)

Cherry-pick of:
- #1703: a non subscription-admin shoudl not deploy cluster-scoped resources by default
- #1704: a non subscription-admin should not deploy cluster-scoped resources via helmrepo or object store

Signed-off-by: Xiangjing Li <xiangli@redhat.com>
@openshift-ci

openshift-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@openshift-ci

openshift-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown

@xiangjingli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud f242573 link true /test sonarcloud

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xiangjingli

Copy link
Copy Markdown
Contributor Author

/hold

@xiangjingli

Copy link
Copy Markdown
Contributor Author

/unhold

@xiangjingli
xiangjingli merged commit 0ddff90 into release-2.15 Aug 18, 2026
11 of 13 checks passed
@xiangjingli
xiangjingli deleted the cherry-pick-1703-1704-release-2.15 branch August 18, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant