Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Firefox.
Firefox currently doesn't support
declarativeContent
, but I've addedpage_action.show_matches
. Though, maybe it's a bit broader than whatbackground.js
matched, also matching the meet.google.com landing page, I think? (But if this is okay, then maybebackground.js
is now obsolete?)I switched from
options_page
tooptions_ui
, because that's supported by both. I also removed the<h1>
and logo from the options page to make it more compact. Specifically, Firefox has a fixed-width container in extension preferences that the logo was scaled to, causing lots of blur.To test storage in Firefox, you have to set an extension ID. I improvised here, but don't know what requirements Mozilla sets for this. Feel free to change before publishing. 🙂
Chrome page action:

Firefox page action:

Chrome preferences:

Firefox preferences:
