Skip to content

chore: add exception message for invalid path value #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: add exception message for invalid path value #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65f6bc9
chore: add exception message for invalid path value
KristianH Jul 25, 2025
5ea84d2
fix
KristianH Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Domain/Value/Link.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ public function __construct(array $values)

Assert::keyExists($values, 'path');

if (null !== $values['path']) {
$path = TrimmedNonEmptyString::fromString($values['path'])->toString();
if (null !== $values['path'] && '' !== $values['path']) {
$path = TrimmedNonEmptyString::fromString($values['path'], 'The value of key "path" is invalid.')->toString();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KristianH i am not so happy with this. Its too generic. Maybe something like The value of key "path" must be an trimmed non empty string

}

$this->path = $path ?? null;
Expand Down
14 changes: 14 additions & 0 deletions tests/Unit/Domain/Value/LinkTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

namespace Storyblok\Api\Tests\Unit\Domain\Value;

use Ergebnis\DataProvider\StringProvider;
use PHPUnit\Framework\Attributes\DataProviderExternal;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\TestCase;
use Storyblok\Api\Domain\Value\Link;
Expand Down Expand Up @@ -153,6 +155,18 @@ public function pathKeyMustExist(): void
new Link($values);
}

#[DataProviderExternal(StringProvider::class, 'blank')]
#[Test]
public function pathMustBeValidString(string $value): void
{
$values = self::faker()->linkResponse(['path' => $value]);

self::expectExceptionMessage('The value of key "path" is invalid.');
self::expectException(\InvalidArgumentException::class);

new Link($values);
}

#[Test]
public function isFolder(): void
{
Expand Down