Merge pull request #458 from storyblok/feat/work-1342

feat(work-1342): fix data-testid case
storyblok · Oct 26, 2023 · 00926ac · 00926ac
2 parents 0255d23 + 50138e1
commit 00926ac
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/src/components/Badge/SbBadge.vue b/src/components/Badge/SbBadge.vue
@@ -1,7 +1,15 @@
 <template>
   <div :class="activeClasses">
-    <SbIcon v-if="isRenderIcon" :name="iconName" :data-testid="`${dataTestId}-icon`"/>
-    <span v-if="hasLabelToRender" class="sb-badge__label" :data-testid="`${dataTestid}-active-label`">
+    <SbIcon
+      v-if="isRenderIcon"
+      :name="iconName"
+      :data-testid="`${dataTestid}-icon`"
+    />
+    <span
+      v-if="hasLabelToRender"
+      class="sb-badge__label"
+      :data-testid="`${dataTestid}-active-label`"
+    >
       <slot>{{ activeLabel }}</slot>
     </span>
     <slot v-else></slot>
@@ -75,7 +83,7 @@ export default {
       activeClasses,
       activeLabel,
       iconName,
-      dataTestid
+      dataTestid,
     }
   },
 }

diff --git a/src/components/Modal/SbModal.vue b/src/components/Modal/SbModal.vue
@@ -104,8 +104,8 @@ export default {
 
   computed: {
     closeButtonDataTestId() {
-      const dataTestId = this.$attrs['data-testid']
-      return dataTestId ? `${dataTestId}-close-button` : 'sb-modal-close-button'
+      const dataTestid = this.$attrs['data-testid']
+      return dataTestid ? `${dataTestid}-close-button` : 'sb-modal-close-button'
     },
 
     computedClasses() {