This repository has been archived by the owner on Jan 27, 2025. It is now read-only.
refactor(WORK-1388): add data-testid in datepicker and textfield #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandacanto
requested review from
lorenaramonda,
marcosh-ramos,
lisilinhart and
emanuelgsouza
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks for your comments @ademarCardoso, maybe can you check again? |
ademarCardoso
approved these changes
Nov 7, 2023
marcosh-ramos
approved these changes
Nov 7, 2023
|
🎉 This PR is included in version 3.19.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PRA I add data-testid to the SbDatepicker and SbTextfield components.
Pull request type
Jira Link: WORK-1388
How to test this PR
Go to preview > Menu > Forms > SbDatepicker
Check if already works.
Go to preview > Menu > Forms > SbTextField
Check if already works.