Update Node.js version #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…release workflow for clarity
ndelangen
changed the title
…target to esnext in tsconfig.json
Sidnioulz
reviewed
Nov 13, 2025
Sidnioulz
reviewed
Nov 13, 2025
…command execution
…e tsup.config.ts in the TypeScript compilation
Member
Author
|
@Sidnioulz I'm at a loss at that error in release... What's going on ? Have you seen this before? |
…json and pnpm-lock.yaml for compatibility reasons
…wJs and moduleDetection options, and clean up unused settings for improved TypeScript configuration.
…on and pnpm-lock.yaml to ensure compatibility with the latest features and improvements.
Sidnioulz
reviewed
Nov 13, 2025
| "moduleDetection": "force", | ||
| "moduleResolution": "bundler", | ||
| "module": "preserve", | ||
| "module": "es2015", |
Member
There was a problem hiding this comment.
@ndelangen I'm wondering if es2015 is actually supported or not. I think we could've kept preserve here, that's what we have in the addon-kit.
Member
Author
There was a problem hiding this comment.
It isn't used by esbuild anyway AFAIK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Published PR as canary version:
2.0.1--canary.36.f3dd7e7.0✨ Test out this PR locally via: