Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(svelte): Use vite-plugin-svelte-docgen #29599

Closed
wants to merge 2 commits into from

Conversation

xeho91
Copy link

@xeho91 xeho91 commented Nov 13, 2024

Moved to #30101.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

code/renderers/svelte/src/docs/extractArgTypes.ts Outdated Show resolved Hide resolved
@jonniebigodes
Copy link
Contributor

@xeho91, thanks for taking the time to put together this pull request. We appreciate it 🙏 !

@JReinhold, can you please take a look when you have a moment so that we can get this in?

Thanks in advance

Copy link

nx-cloud bot commented Nov 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1c98af6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@xeho91
Copy link
Author

xeho91 commented Nov 18, 2024

Hey!

Thanks for the update! Please forgive me for causing any confusion. I'm changing this PR to a draft.

Reason:
I've been making more progress on this case, where I also did some auto-grouping properties. Is related to this thread on Discord. This PR is currently a small piece of this case, and I'd like to put this together with the auto-grouping feature.

@xeho91 xeho91 marked this pull request as draft November 18, 2024 14:26
@jonniebigodes
Copy link
Contributor

@xeho91 no problem, and there is no need to apologize whatsoever. Appreciate you changing it to a draft pull request 🙏 ! Looking forward to seeing this added.

Have a great day.

Stay safe

@xeho91 xeho91 changed the title feat(svelte): filter out event handlers types with on:* when svelte@5 is in use feat(svelte): Use vite-plugin-svelte-docgen Dec 10, 2024
@xeho91
Copy link
Author

xeho91 commented Dec 18, 2024

Closing in favor of #30101.

@xeho91 xeho91 closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants