-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve get all trees #174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to get the tree from
getDocsTreeFromPath
to get the tree but the slug returned included the actual version. In this PR I'm improving the way we get the tree with the right slugs, reducing the need to modify it after in multiple places. The new structure is as followed:getDocsTreeFromPath(): RawTreeProps[]
This function will get the raw data of a tree at a specific path. This function doesn't include
slug
anymore.getAllTrees(): TreeProps[]
This new function will return the list of all trees with the right slug. The latest version will not get the version in the url for example. I also improved the way we transform the slug to make sure it works even if there's a version in the name of the page.
To get the tree for a specific version, just call this function and look for the tree for a specific version like this:
This PR also fixes some slugs that were generated by mistake in docs like
versions
or empty slugs.