fix(i18n): French labels name unrelated actions and omit two required translations #529

Runtime or environment

• Baseline commit: 3926d21
• Package under test: gridcraft-ui-egui v0.5.0.

Summary

Selecting Français can label the Ruler control as Save As and replace the Save As label with a PDF-export description. Two Header & Footer options also lack French entries, causing the existing translation-coverage test to fail. The public translation lookup reproduces these results; the application window was not opened.

Steps to reproduce

1. Set TASK_TARGET_DIR to a disposable build directory. From the repository root at the stated baseline, run the existing focused test:

CARGO_TARGET_DIR="$TASK_TARGET_DIR" CARGO_BUILD_JOBS=4 nice -n 10 cargo test -p gridcraft-ui-egui --lib i18n::tests::translations_are_unique_and_preserve_unknown_text -- --exact

2. Observe the failure reporting missing French: Different First Page.
3. Inspect the relevant catalog entries with this read-only command:

rg -n '"Ruler"|"Save As"|Different First Page|Different Odd & Even Pages' crates/ui-egui/src/i18n/fr.rs

4. The following public-API test also reproduces the lookup results. Save it as crates/ui-egui/tests/french_catalog_probe.rs, run the command below, then remove that disposable test file.

use gridcraft_ui_egui::i18n::Language;

#[test]
fn french_catalog_lookup_observation() {
    assert_eq!(Language::parse("fr"), Some(Language::Fr));
    assert!(Language::ALL.contains(&Language::Fr));
    for (key, actual) in [
        ("Ruler", "Enregistrer sous"),
        ("Save As", "Enregistrer la feuille sous forme de document PDF en conservant sa mise en page."),
        ("Different First Page", "Different First Page"),
        ("Different Odd & Even Pages", "Different Odd & Even Pages"),
        ("Data", "Données"),
    ] {
        assert_eq!(Language::Fr.tr(key), actual);
        assert_eq!(Language::En.tr(key), key);
        println!("{key:?} => {:?}", Language::Fr.tr(key));
    }
}

CARGO_TARGET_DIR="$TASK_TARGET_DIR" CARGO_BUILD_JOBS=4 nice -n 10 cargo test -p gridcraft-ui-egui --test french_catalog_probe french_catalog_lookup_observation -- --exact --nocapture

The same test body was executed during verification under a disposable filename and passed. Its assertions capture the erroneous baseline outputs. They are observation checks, not desired regression expectations.

Expected behavior

French interface labels should describe the same controls and actions as their English keys. Ruler should identify the ruler, and Save As should identify saving under another name or location. The existing coverage check also requires a nonempty French translation for every reference key, including Different First Page and Different Odd & Even Pages.

Actual behavior

The focused coverage test exits with status 101 and reports missing French: Different First Page. The public lookup returns Enregistrer sous, meaning Save As, for Ruler, and Enregistrer la feuille sous forme de document PDF en conservant sa mise en page., a PDF-export description, for Save As. Both missing options return their original English labels. The Data control returns Données, confirming that French lookup works for an unaffected key.

Read-only catalog comparison finds 379 French keys against 381 reference keys. The only missing keys are Different First Page and Different Odd & Even Pages. Source inspection establishes that the View Ruler checkbox, Backstage Save As navigation, and Header & Footer options use this lookup. No rendered UI behavior was directly observed.

Evidence

• Expected source: crates/ui-egui/src/i18n.rs:1 documents interface translation and English fallback; crates/ui-egui/src/i18n.rs:113 documents the public label lookup; crates/ui-egui/src/i18n.rs:589 requires French coverage of the reference keys.
• Failure source: crates/ui-egui/src/i18n/fr.rs:324 maps Ruler to Save As text, and crates/ui-egui/src/i18n/fr.rs:331 maps Save As to a PDF-export description; the focused test and public-API observation test reproduce the contrary results.
• Evidence provenance: observed
• Local verification: reproduced
• Reproduction completeness: complete

The relevant UI consumers are crates/ui-egui/src/ribbon.rs:2112, crates/ui-egui/src/backstage.rs:166, and crates/ui-egui/src/paper_view.rs:656. The View language switcher includes Français, and the language-setting command accepts its code.

Restoration check

The existing focused coverage test should pass with both missing options translated. Public French lookup for Ruler and Save As should describe their own actions rather than the recorded unrelated actions. Check those meanings independently of coverage, because a nonempty wrong translation passes the coverage assertion. Preserve the correct Data translation and English labels as controls. Review the remaining French entries for the same mismatch; passing the two spot checks alone does not establish that the catalog is correct.

Additional context

Related proposed fixes: PR #454 addresses the same incorrect French labels and missing keys. PR #449 adds the two missing keys but leaves the incorrect existing labels, and PR #455 was closed without merging in favor of PR #454. This report provides independent lookup and coverage evidence for the tested main revision.

Triage assessment

• Impact level: P2
• Assessment status: supported
• Impact basis: A supported language gives misleading names to navigation and controls, and its required coverage check fails at the baseline. These failures recur for the affected keys. No calculation error, data loss, or failure to execute the underlying command was observed.
• Workaround status: available
• Workaround basis: Selecting English uses the original labels, as verified by the public lookup probe. The switcher displays language choices in their own names, so English remains identifiable from the French interface. This preserves the controls' meaning while giving up French labels.