Repository navigation
Conversation
7 tasks
…ainsString="0" next to them made Excel refuse the file); a date group with a blank date no longer writes containsSemiMixedTypes; date groups are written without sortType and read back ascending; a single-item report filter is read through the field's items; two value fields without a column field write firstHeaderRow=0 and hideValuesRow. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
HyakoV3
force-pushed
the
fix/1447-pivot-xlsx
branch
from
October 16, 2026 00:46
bbf2e61 to
a306ce7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1447 (items 1, 3, 4, 5 and 6 of its list; the issue stays open for 2 and 7).
All in
crates/xlsx/src/pivot.rs:<sharedItems>flags, as Excel writes them. Before,containsString="0"next to them made Excel refuse the file (even with repair).pageField@itemis read through the pivot field's<items>(x= shared item), soQty = 3is no longer read as another item.containsSemiMixedTypes="0"is only written when there is no blank.sortType(Excel sorted its labels as text) and a date group withoutsortTypereads back as ascending.firstHeaderRow="0"plus<x14:pivotTableDefinition hideValuesRow="1"/>, so Excel 365 adds noValuesrow (no more#SPILL!below the report). One value field is unchanged.Not in this PR: 2 (source headers with leading/trailing spaces: engine + xlsx header handling) and 7 (PivotChart link needs the file name threaded to the writer). Happy to do them next; they touch other files.
Tests: cache flags for the six column kinds of the issue's table, date-group flags with and without a blank, hideValuesRow, and the report-filter read. The three write-side tests fail on
main. The existing round-trip fixture's Years group now usesPivotSort::Asc(the default) since a date group withoutsortTypereads as ascending.cargo xtask cipasses.Open PRs #722, #474, #498, #719 and #684 touch the same files, so a rebase may be needed.
🤖 Generated with Claude Code