[dotCooCoo]

Summary

GridCraft's status bar always showed Average, Count and Sum for a selection of several cells, and a right-click on it did nothing. Microsoft's Excel status bar options page says "If you want to customize the status bar, right-click it, and then click the options that you want". It lists Average, Count and Sum as selected by default, and Numerical Count, Minimum and Maximum as "not selected by default".

Changes

• A right-click on the status bar opens a menu with a check item for Average, Count, Numerical Count, Minimum, Maximum and Sum. The status bar shows the statistics that are checked, in that order.
• The text on the status bar (the mode, the statistics and the other messages) can no longer be selected, so a right-click on it opens the menu as well. The zoom and view controls handle their own clicks as before.
• New command view.statusBar {average?, count?, numericalCount?, minimum?, maximum?, sum?} sets the statistics and returns all six. The choice is a preference and is saved in prefs.json. A prefs.json without it keeps the defaults.
• docs/ui-parity.md gets the status bar row, the header's Last updated date and Change list, and a revision history row. ROADMAP.md gets a progress log row.

The page does not give the text the status bar shows for the new statistics. GridCraft labels them with the option names (Numerical Count: 3, Minimum: -1, Maximum: 9). Minimum, Maximum and Sum show only when the selection holds a number. Count and Numerical Count show when it holds any value. The other options on the page (Cell Mode, Zoom Slider and the rest) stay as they are.

Tests

• cmd::view::tests::status_bar_statistics_default_to_average_count_and_sum_and_turn_on_one_at_a_time checks the defaults, that a call changes only the statistics it names, and that an older or partial prefs.json keeps the defaults.
• tabs::tests::status_bar_shows_the_statistics_that_are_turned_on_in_order checks the text for numbers mixed with text, for text only, and for one cell.
• tests/it/status_bar_menu.rs (egui_kittest) right-clicks an empty part of the status bar, clicks Minimum, and checks that Minimum: -1 is shown. A second test right-clicks on Sum: 12 and on Ready and checks that the menu opens.

None of these builds on main, which has no status bar preference. Each test fails on this branch when its part is broken: view.statusBar ignoring its parameters, Minimum shown while it is off, the menu removed, and the status bar labels left selectable.

Before the gate, these targeted checks were run: cargo fmt --all -- --check, cargo clippy -p gridcraft-engine -p gridcraft-ui-egui --all-targets -- -D warnings, cargo test -p gridcraft-engine, cargo test -p gridcraft-ui-egui, cargo xtask assets, cargo xtask layers, cargo xtask parity --check and cargo xtask keytips --check. cargo test -p gridcraft-ui-egui had one failure, header_autofit::table_filter_autofit_works_through_command_and_header_double_click, which also fails on main on this machine and which #2273 fixes.

Checks

On Windows 11 (x86-64) with rustc 1.99.1, on top of main at f284f6a, with #2273 merged in:

• cargo xtask ci passes its 10 steps: 2,274 tests passed, 0 failed, 1 ignored.

git merge-tree reports no conflicts with main at 48d9ba2. With #2410 or #2414 merged, docs/ui-parity.md conflicts in the header's Last updated / Change list and the top revision row, and with #2414 ROADMAP.md conflicts in the top progress log row; both sides are kept.

Summary by CodeRabbit

• New Features
  • Right-click the status bar to choose which selection statistics to display: Average, Count, Numerical Count, Minimum, Maximum, and Sum.
  • Average, Count, and Sum are enabled by default; Numerical Count, Minimum, and Maximum are off by default.
  • Your choices are saved and restored between sessions. Statistical values follow the active cell’s number format.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: storytold/gridcraft
• Branch: main
• File: .coderabbit.yaml
• Commit: 48d9ba2
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 9d3f95eb-ab14-49e1-bd7e-3f7d60c9dc23

Commits

Reviewing files that changed from the base of the PR and between 48d9ba2 and 7bc390d.

Files selected for processing: 7

• ROADMAP.md
• crates/engine/src/cmd/view.rs
• crates/engine/src/lib.rs
• crates/ui-egui/src/tabs.rs
• crates/ui-egui/tests/it/main.rs
• crates/ui-egui/tests/it/status_bar_menu.rs
• docs/ui-parity.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

Walkthrough

The status bar now has a right-click menu for six selection statistics. Preferences store the enabled options, and the view.statusBar command updates and returns them. The UI displays enabled statistics when selection and data conditions are met.

Changes: Status-bar statistics

Layer / File(s)	Summary
Preference contract and query command crates/engine/src/lib.rs, crates/engine/src/cmd/view.rs	Adds serialized settings for Average, Count, Numerical Count, Minimum, Maximum, and Sum. Average, Count, and Sum are enabled by default. The view.statusBar command updates supplied Boolean settings and returns all six values. Tests cover defaults, partial updates, non-Boolean inputs, and serialization.
Status-bar menu and statistics display crates/ui-egui/src/tabs.rs, crates/ui-egui/tests/it/*, docs/ui-parity.md, ROADMAP.md	Adds a right-click menu for the six statistics and displays enabled statistics for qualifying multi-cell selections. Numeric results use the active cell’s number format, with a fallback for General format. Tests cover menu interaction, values, preference filtering, and single-cell selections. The documentation records the options and defaults.

Priority: Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  actor User
  participant StatusBar
  participant status_bar_menu
  participant view.statusBar
  participant Prefs
  participant selection_statistics
  User->>StatusBar: Right-click status bar
  StatusBar->>status_bar_menu: Open statistics menu
  User->>status_bar_menu: Toggle a statistic
  status_bar_menu->>view.statusBar: Submit statistic key and Boolean value
  view.statusBar->>Prefs: Update preference
  StatusBar->>selection_statistics: Read preferences and selection statistics
  selection_statistics-->>StatusBar: Return enabled statistics
  StatusBar-->>User: Display formatted statistics

Loading

Suggested reviewers: echelon, marcoarnulfo, vangel76

Merge Risk: Minimal · up to 7bc39

No confirmed issue blocks merging the status-bar statistics change.

Security architecture risk: Minimal · up to 7bc39

The new settings control only which statistics appear for the current selection. They retain the existing defaults and preference storage behavior. The reviewed changes introduce no material security risk.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The new command's direct writable scope is the current session's six display preferences, which may persist across workbooks. Its response contains preference flags, not workbook data. The rendering change exposes additional aggregates of the same selected cells already used for status-bar statistics.

Trust Boundaries and Controls

• observed — The command is available without an open workbook, but its handler only assigns Boolean preferences. The query designation disables journaling and undo; it does not bypass command enablement checks. The inspected handler performs no file access, network request, code execution or authorization-state mutation.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 18 functions across 5 files. (2 skipped: …	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: a status-bar right-click statistics menu with the newly available Numerical Count, Minimum, and Maximum options.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 18 functions across 5 files. (2 skipped: 2 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}