-
Notifications
You must be signed in to change notification settings - Fork 779
feat(skills): support loading skills from GitHub/Git URLs #2091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dgallitelli
wants to merge
9
commits into
strands-agents:main
Choose a base branch
from
dgallitelli:feat/skills-github-url-loading
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a7bddae
feat(skills): support loading skills from GitHub/Git URLs
83966f6
feat(skills): support GitHub /tree/ URLs for nested skills
7f89fd8
fix(skills): address review feedback on URL loading
393dcd7
refactor(skills): replace git clone with HTTPS-only fetch
d049e09
fix(skills): address v2 review feedback
bfa2951
simplify(skills): remove GitHub URL resolution per maintainer feedback
b11b4e3
simplify(skills): inline URL fetch into Skill, remove _url_loader.py
8db72a7
fix(skills): fix stale docstring, add invalid content test
759d822
fix(skills): update set_available_skills docstring, add duplicate URL…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: Codecov flags the duplicate-skill-name warning on line 308 (
if skill.name in resolved) as uncovered. There's no test case where two URL sources resolve to a skill with the same name.Suggestion: Add a test in
TestResolveUrlSkills: