refactor(agent): convert printer to plugin pattern#689
Open
zastrowm wants to merge 2 commits intostrands-agents:mainfrom
Open
refactor(agent): convert printer to plugin pattern#689zastrowm wants to merge 2 commits intostrands-agents:mainfrom
zastrowm wants to merge 2 commits intostrands-agents:mainfrom
Conversation
Code Review: ✅ ApproveAssessment: Approve Clean internal refactor that converts AgentPrinter from a directly-wired implementation to the Plugin pattern, improving extensibility and consistency with other SDK components like Review Summary
Good work on maintaining the same functionality while making the architecture more consistent. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AgentPrinterwas wired directly into the agent loop as a private_printerfield, with the agent manually calling_printer?.processEvent(event)on every yielded event.AgentPrinternow implementsPluginand registers its own hook callbacks viainitAgent(). ThePrinterinterface has been removed as it was only used internally.The
printer: falseoption still suppresses it and default behavior is unchanged.Related Issues
#270
Documentation PR
Internal refactor; no public API changes requiring doc updates.
Type of Change
Refactor
Testing
How have you tested the change?
npm run checkChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.