test multiple coinbase outputs round-trip#325
Draft
xyephy wants to merge 2 commits intostratum-mining:mainfrom
Draft
test multiple coinbase outputs round-trip#325xyephy wants to merge 2 commits intostratum-mining:mainfrom
xyephy wants to merge 2 commits intostratum-mining:mainfrom
Conversation
d0fb197 to
1706f1c
Compare
1706f1c to
1a2b6db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds integration tests that verify all coinbase outputs survive the full
round-trip through the mining stack (TP -> Pool -> Translator -> Minerd).
Bitcoin Core block acceptance is used as the assertion — if any output is
dropped or mangled, the block is rejected.
tp_coinbase_outputs_round_trip— witness commitment output round-triptp_multiple_coinbase_outputs_round_trip— 3+ OP_RETURN outputs round-trip,requires a custom Bitcoin Core build with
-testmulticoinbasesupportCloses #58