Remove need for reallocations for MacOS implementation#37
Closed
Kijewski wants to merge 1 commit intostrawlab:mainfrom
Kijewski:pr-less-realloc-mac
Closed
Remove need for reallocations for MacOS implementation#37Kijewski wants to merge 1 commit intostrawlab:mainfrom Kijewski:pr-less-realloc-mac
Kijewski wants to merge 1 commit intostrawlab:mainfrom
Kijewski:pr-less-realloc-mac
Conversation
Kijewski
commented
Apr 14, 2022
| ~/.cargo/git/db/ | ||
| target/ | ||
| - run: cargo test --workspace --all-targets | ||
| - run: cargo run --example get_timezone |
Collaborator
Author
There was a problem hiding this comment.
I don't know how to change the timezone of the runner, so don't know if there is a better option than to at the result whether it looks sane.
Kijewski
commented
Apr 14, 2022
Comment on lines
+8
to
+9
| str1.truncate(match str1.split_ascii_whitespace().next() { | ||
| Some(s) => s.len(), |
Collaborator
Author
There was a problem hiding this comment.
I put the truncation outside of the match. Inside the Some() arm, the string is still borrowed. Cf. rust-lang/rust#59159
Member
|
I had a look at this myself and discovered the Thanks for prompting me to look into this. Recent changes released as 0.1.33. |
Collaborator
Author
|
Nice, that much prettier! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.