Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: useLanguage sensor #2602

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: useLanguage sensor #2602

wants to merge 2 commits into from

Conversation

alvvaro
Copy link

@alvvaro alvvaro commented Oct 24, 2024

Description

This hook tracks the value of the lang attribute of the document global object (the <html> tag). Its signature is the same as useState, returning a tuple with the value and a dispatcher. It takes no arguments.

It uses a MutationObserver to track the changes and causes a rerender, whether if it is updated from inside React or not.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

  • Read the Contributing Guide
  • Perform a code self-review
  • Comment the code, particularly in hard-to-understand areas
  • Add documentation
  • Add hook's story at Storybook
  • Cover changes with tests
  • Ensure the test suite passes (yarn test)
  • Provide 100% tests coverage
  • Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • Make sure types are fine (yarn lint:types).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant