Skip to content

Hide Twitch Both on Mac for now #5984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gettinToasty wants to merge 1 commit into from
+3 −12
Closed

Hide Twitch Both on Mac for now #5984

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions app/services/platforms/twitch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import { ENotificationType, NotificationsService } from '../notifications';
import { $t } from '../i18n';
import { IncrementalRolloutService } from 'app-services';
import { EAvailableFeatures } from 'services/incremental-rollout';
import { getOS, OS } from 'util/operating-systems';

export interface ITwitchStartStreamOptions {
title: string;
Expand Down Expand Up @@ -85,19 +86,9 @@ class TwitchServiceViews extends ViewHandler<ITwitchServiceState> {
return this.getServiceViews(IncrementalRolloutService);
}

/**
* TODO: This variable currently needs to be different for preview vs live releases
* while twitch is in closed beta for this feature, meaning we need to change it
* every time we release to production and then change it back
*
* Preview releases: "twitchDualStreamPreview"
* Production releases: "twitchDualStream"
*/
get hasTwitchDualStreamAccess() {
const featureName = Utils.env.SLOBS_PREVIEW
? EAvailableFeatures.twitchDualStreamPreview
: EAvailableFeatures.twitchDualStream;
return this.incrementalRolloutServiceView.featureIsEnabled(featureName);
if (getOS() === OS.Mac) return false;
return this.incrementalRolloutServiceView.featureIsEnabled(EAvailableFeatures.twitchDualStream);
}
}

Expand Down
Loading