Skip to content

Conversation

@sfc-gh-bnisco
Copy link
Contributor

@sfc-gh-bnisco sfc-gh-bnisco commented Nov 20, 2025

What changed?

  • Replaced pip with uv in installation instructions
  • Added comprehensive development setup instructions to the README
  • Updated the Bokeh version update script to work with the new project structure

Copy link
Contributor Author

sfc-gh-bnisco commented Nov 20, 2025

This was referenced Nov 20, 2025
@sfc-gh-bnisco sfc-gh-bnisco force-pushed the feat-ccv2-dual-test branch 2 times, most recently from c4af6e0 to 3b3e96b Compare November 20, 2025 00:50
Copilot finished reviewing on behalf of sfc-gh-bnisco November 20, 2025 18:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project's tooling and documentation to reflect a migration from pip to uv and from setup.py to pyproject.toml configuration. It provides comprehensive development setup instructions and modernizes the Bokeh version update automation script.

Key changes:

  • Replaced all pip commands with uv in installation and development instructions
  • Added detailed development setup guide with prerequisites, environment setup, and testing instructions
  • Refactored the Bokeh version update script to work with pyproject.toml instead of setup.py, including support for multiple configuration files and TypeScript loader updates

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
scripts/update_bokeh_version.py Migrated from setup.py to pyproject.toml for version management, added TOML parsing, updated file paths to match new project structure (frontend/src/assets), and added TypeScript loader update functionality
README.md Updated installation commands to use uv instead of pip, added comprehensive development section with environment setup, build instructions, and testing workflows

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@sfc-gh-nbellante sfc-gh-nbellante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sfc-gh-bnisco sfc-gh-bnisco marked this pull request as ready for review November 21, 2025 19:43
@sfc-gh-bnisco sfc-gh-bnisco force-pushed the feat-ccv2-dual-test branch 3 times, most recently from 684d3da to 98c3504 Compare November 24, 2025 22:12
@sfc-gh-bnisco sfc-gh-bnisco force-pushed the feat-ccv2-dual-scripts branch 2 times, most recently from 3f1dd80 to a26d63b Compare November 24, 2025 23:50
@sfc-gh-bnisco sfc-gh-bnisco force-pushed the feat-ccv2-dual-test branch 2 times, most recently from 5177733 to 5010145 Compare November 25, 2025 03:36
@sfc-gh-bnisco sfc-gh-bnisco changed the base branch from feat-ccv2-dual-test to graphite-base/42 November 25, 2025 22:41
@graphite-app graphite-app bot changed the base branch from graphite-base/42 to main November 25, 2025 22:42
@sfc-gh-bnisco sfc-gh-bnisco merged commit 7881726 into main Nov 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants