Replace readlink with greadlink #61
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When working with Travis builds I sometimes have to run the build locally to simulate what happens on Travis server. This is difficult because macOS /usr/bin/readlink is different from Linux's readlink. One solution is to use greadlink which can be installed with 'brew install coreutils'. Coreutils readlink is prefixed with a 'g' on macOS. See the difference between implementations: kkn@kare-mbp ~/src/github.com/streamr-dev/streamr-docker-dev master U % readlink streamr-docker-dev/bin.sh -f kkn@kare-mbp ~/src/github.com/streamr-dev/streamr-docker-dev master U % greadlink streamr-docker-dev/bin.sh -f /Users/kkn/src/github.com/streamr-dev/streamr-docker-dev/streamr-docker-dev/bin.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with Travis builds I sometimes have to run the build
locally to simulate what happens on Travis server.
This is difficult because macOS /usr/bin/readlink is different from
Linux's readlink.
One solution is to use greadlink which can be installed with
brew install coreutils. Coreutils readlink is prefixed with a 'g' on macOS.See the difference between implementations: