DXP-2564 Implement settings command - #10
Merged
Merged
Conversation
valkovich-ds
force-pushed
the
add-run-command-2
branch
from
February 3, 2026 06:56
bbd0194 to
572d135
Compare
valkovich-ds
force-pushed
the
add-settings-command
branch
from
February 3, 2026 06:59
ed164c6 to
a934fbb
Compare
| @@ -0,0 +1,4 @@ | |||
| package com.streamx.cli.commands.settings.list; | |||
|
|
|||
| public record Property(String key, String value) { | |||
Contributor
There was a problem hiding this comment.
Do we need 2 Data models for settings property? What is the difference between this record and GetCommandResult?
| mixinStandardHelpOptions = true, | ||
| description = "Get configuration property" | ||
| ) | ||
| public class GetCommand extends AbstractCommand<GetCommandResult> { |
Contributor
There was a problem hiding this comment.
In my opinion this command should return only value. @marekczajkowski WDYT?
| mixinStandardHelpOptions = true, | ||
| description = "Display configuration properties" | ||
| ) | ||
| public class ListCommand extends AbstractCommand<List<Property>> { |
Contributor
There was a problem hiding this comment.
This command should return Map. @marekczajkowski WDYT?
| <surefire-plugin.version>3.2.5</surefire-plugin.version> | ||
| <compiler-plugin.version>3.13.0</compiler-plugin.version> | ||
| <checkstyle-plugin.version>3.6.0</checkstyle-plugin.version> | ||
| <argLine>--add-opens java.base/java.lang=ALL-UNNAMED</argLine> |
Contributor
There was a problem hiding this comment.
Why do we need this? Leave in-code comment with the reason.
| public class ListCommand extends AbstractCommand<List<Property>> { | ||
| @Override | ||
| public String getTextOutput(CommandResult<List<Property>> result) { | ||
| if (result.result.isEmpty()) { |
Contributor
There was a problem hiding this comment.
We should rename result field to data and use encapsulation via getter method
kamilchociej
approved these changes
Feb 11, 2026
valkovich-ds
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Type of the Changes
🛠 Changes being made
✅ Checklist