Skip to content

[DXP-1946] Open direct overview page on dashboard started #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgardo-ds merged 2 commits into from
Jun 27, 2025
Merged

[DXP-1946] Open direct overview page on dashboard started #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23ecc7d
[DXP-1946] Open direct overview page on dashboard started
jgardo-ds Jun 20, 2025
725deb5
Merge branch 'main' into bugfix/DXP-1964-dev-dashboard-initial-error
jgardo-ds Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/java/dev/streamx/cli/command/dev/BrowserOpener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ public void tryOpenBrowser() {
try {
if (Desktop.isDesktopSupported()) {
Desktop desktop = Desktop.getDesktop();
URI meshManagerUri = new URI("http://localhost:" + devConfig.dashboardPort());
String entryUrl = "http://localhost:%d/overview".formatted(devConfig.dashboardPort());
URI meshManagerUri = new URI(entryUrl);
desktop.browse(meshManagerUri);
} else {
logger.warn("Opening browser is not supported");
Expand Down
9 changes: 7 additions & 2 deletions core/src/main/java/dev/streamx/cli/command/dev/DashboardRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,13 @@ public void startStreamxDashboard(String meshPath, String meshDirectory,
meshPath,
meshDirectory,
projectDirectory
).withStartupTimeout(Duration.ofSeconds(CONTAINER_TIMEOUT_IN_SECS))
.withNetwork(network);
)
.withNetwork(network)
.waitingFor(Wait.forHttp("/q/health")
.forPort(8080)
)
.withStartupTimeout(Duration.ofSeconds(CONTAINER_TIMEOUT_IN_SECS));

dashboardContainer.start();

print("StreamX Dashboard started on http://localhost:" + devConfig.dashboardPort());
Expand Down
6 changes: 2 additions & 4 deletions core/src/test/java/dev/streamx/cli/command/dev/DevCommandTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package dev.streamx.cli.command.dev;

import static dev.streamx.cli.command.util.MeshTestsUtils.cleanUpMesh;
import static org.assertj.core.api.Assertions.assertThat;

import com.github.dockerjava.api.DockerClient;
Expand All @@ -9,8 +10,6 @@
import dev.streamx.cli.command.dev.event.DevReady;
import dev.streamx.runner.event.MeshReloadUpdate;
import dev.streamx.runner.event.MeshStarted;
import dev.streamx.runner.validation.DockerContainerValidator;
import dev.streamx.runner.validation.DockerEnvironmentValidator;
import io.quarkus.arc.properties.IfBuildProperty;
import io.quarkus.test.junit.QuarkusTestProfile;
import io.quarkus.test.junit.TestProfile;
Expand Down Expand Up @@ -70,8 +69,7 @@ void awaitDockerResourcesAreRemoved() {
Set<String> cleanedUpContainers =
Set.of("pulsar", "pulsar-init", "streamx-dashboard",
"rest-ingestion", "relay", "web-delivery-service");
DockerClient client = new DockerEnvironmentValidator().validateDockerClient();
new DockerContainerValidator().verifyExistingContainers(client, cleanedUpContainers);
cleanUpMesh(cleanedUpContainers);

return true;
} catch (Exception e) {
Expand Down
7 changes: 2 additions & 5 deletions core/src/test/java/dev/streamx/cli/command/run/RunCommandTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
package dev.streamx.cli.command.run;

import static dev.streamx.cli.command.util.MeshTestsUtils.cleanUpMesh;
import static org.assertj.core.api.Assertions.assertThat;

import com.github.dockerjava.api.DockerClient;
import dev.streamx.cli.command.MeshStopper;
import dev.streamx.cli.command.run.RunCommandTest.RunCommandProfile;
import dev.streamx.runner.event.MeshStarted;
import dev.streamx.runner.validation.DockerContainerValidator;
import dev.streamx.runner.validation.DockerEnvironmentValidator;
import io.quarkus.arc.properties.IfBuildProperty;
import io.quarkus.test.junit.QuarkusTestProfile;
import io.quarkus.test.junit.TestProfile;
Expand Down Expand Up @@ -38,8 +36,7 @@ void awaitDockerResourcesAreRemoved() {
Set<String> cleanedUpContainers =
Set.of("pulsar", "pulsar-init",
"rest-ingestion", "relay", "web-delivery-service");
DockerClient client = new DockerEnvironmentValidator().validateDockerClient();
new DockerContainerValidator().verifyExistingContainers(client, cleanedUpContainers);
cleanUpMesh(cleanedUpContainers);

return true;
} catch (Exception e) {
Expand Down
22 changes: 22 additions & 0 deletions core/src/test/java/dev/streamx/cli/command/util/MeshTestsUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
package dev.streamx.cli.command.util;

import com.github.dockerjava.api.DockerClient;
import dev.streamx.runner.validation.DockerContainerValidator;
import dev.streamx.runner.validation.DockerEnvironmentValidator;
import java.util.Set;

public class MeshTestsUtils {
public static void cleanUpMesh(Set<String> cleanedUpContainers) {
DockerClient client = new DockerEnvironmentValidator().validateDockerClient();
for (String container : cleanedUpContainers) {
try {
client.removeContainerCmd(container)
.withForce(true)
.exec();
} catch (Exception ignored) {
// Ignore
}
}
new DockerContainerValidator().verifyExistingContainers(client, cleanedUpContainers);
}
}