Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Beta] Add tax components #111

Merged
merged 5 commits into from
Apr 19, 2024
Merged

[Beta] Add tax components #111

merged 5 commits into from
Apr 19, 2024

Conversation

kevinpeters-stripe
Copy link

Add tax-registrations and tax-settings components.

Add `tax-settings` and `tax-registrations` component
@kevinpeters-stripe kevinpeters-stripe changed the title feat: tax [Beta] Add tax components Apr 15, 2024
@@ -42,7 +44,9 @@ export const componentNameMapping: Record<
"financial-account": "stripe-connect-financial-account",
"financial-account-transactions":
"stripe-connect-financial-account-transactions",
documents: "stripe-connect-documents"
documents: "stripe-connect-documents",
"tax-registrations": "stripe-connect-tax-registrations",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm, there aren't any props on these components yes?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! No props!

@kevinpeters-stripe
Copy link
Author

Will merge the PR in react-connect-js tomorrow: stripe/react-connect-js#83

Copy link
Contributor

@jorgea-stripe jorgea-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinpeters-stripe kevinpeters-stripe merged commit 73bb593 into beta Apr 19, 2024
2 checks passed
@kevinpeters-stripe kevinpeters-stripe deleted the add-tax-components-beta branch April 19, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants