Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update id document translation #8575

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ccen-stripe
Copy link
Contributor

@ccen-stripe ccen-stripe commented Jun 3, 2024

Summary

Use id document instead of id card

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Jun 3, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │     2 MiB │     2 MiB │     +3 B │   4.3 MiB │   4.3 MiB │      0 B 
     arsc │     1 MiB │     1 MiB │ -3.2 KiB │     1 MiB │     1 MiB │ -3.2 KiB 
 manifest │   2.3 KiB │   2.3 KiB │      0 B │   8.1 KiB │   8.1 KiB │      0 B 
      res │ 301.5 KiB │ 301.5 KiB │      0 B │   455 KiB │   455 KiB │      0 B 
   native │   7.3 MiB │   7.3 MiB │      0 B │  18.4 MiB │  18.4 MiB │      0 B 
    asset │   1.5 MiB │   1.5 MiB │      0 B │   1.5 MiB │   1.5 MiB │      0 B 
    other │    87 KiB │    87 KiB │     -1 B │ 161.5 KiB │ 161.5 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  12.2 MiB │  12.2 MiB │ -3.2 KiB │  25.8 MiB │  25.8 MiB │ -3.2 KiB 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21651 │ 21651 │ 0 (+0 -0) 
   types │  6873 │  6873 │ 0 (+0 -0) 
 classes │  5638 │  5638 │ 0 (+0 -0) 
 methods │ 31466 │ 31466 │ 0 (+0 -0) 
  fields │ 18327 │ 18327 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff      
─────────┼──────┼──────┼───────────
 configs │  164 │  164 │ 0         
 entries │ 3404 │ 3404 │ 0 (+2 -2)
APK
     compressed      │    uncompressed     │                        
──────────┬──────────┼──────────┬──────────┤                        
 size     │ diff     │ size     │ diff     │ path                   
──────────┼──────────┼──────────┼──────────┼────────────────────────
    1 MiB │ -3.2 KiB │    1 MiB │ -3.2 KiB │ ∆ resources.arsc       
    2 MiB │     +3 B │  4.3 MiB │      0 B │ ∆ classes.dex          
 25.9 KiB │     -2 B │ 63.9 KiB │      0 B │ ∆ META-INF/MANIFEST.MF 
 29.1 KiB │     +1 B │   64 KiB │      0 B │ ∆ META-INF/CERT.SF     
──────────┼──────────┼──────────┼──────────┼────────────────────────
  3.1 MiB │ -3.2 KiB │  5.4 MiB │ -3.2 KiB │ (total)
ARSC
ENTRIES:

   old  │ new  │ diff      
  ──────┼──────┼───────────
   3404 │ 3404 │ 0 (+2 -2) 
  + string/stripe_back_of_id_document
  + string/stripe_front_of_id_document
  
  - string/stripe_back_of_id
  - string/stripe_front_of_id

@ccen-stripe ccen-stripe enabled auto-merge (squash) June 20, 2024 22:53
Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stripe-android ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 7:09pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants