Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Add an HTTP wrapper to the gRPC daemon #914

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomer-stripe
Copy link
Collaborator

Reviewers

r? @
cc @stripe/developer-products

Summary

do not merge

Original PR is #899. Revert in #913 because there's an open dependabot issue for an older version of gin-gonic that hasn't been updated in coder/websocket#345 (this can be merged once that's resolved or github.com/improbable-eng/grpc-web removes the websocket dependency entirely)

* The daemon can spin up an http grpc server in parallel for web clients

* Go back to the non-hardcoded ip

* Add comment for exported server function

* Return the right header in the required header check for the daemon

* When the request errors, mention both headers otherwise the logic gets weird

* Remove extra newline

Co-authored-by: Tomer Elmalem <[email protected]>
@tomer-stripe tomer-stripe changed the title [wip] Add an HTTP wrapper to the gRPC daemon (#899) [wip] Add an HTTP wrapper to the gRPC daemon Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants