Add internal "Native Link" switch #4205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚨 New dead code detected in this PR: PayWithLinkViewController.swift:28 warning: Parameter 'payWithLinkViewController' is unused
LinkVerificationController.swift:18 warning: Property 'selfRetainer' is assigned, but never used
LinkVerificationController.swift:26 warning: Function 'present(from:completion:)' is unused
PaymentSheet+Link.swift:32 warning: Parameter 'payWithLinkWebController' is unused
PaymentSheet+Link.swift:41 warning: Parameter 'completion' is unused
PaymentSheet+Link.swift:88 warning: Function 'verifyLinkSessionIfNeeded(with:intent:completion:)' is unused
PaymentSheet+Link.swift:151 warning: Parameter 'payWithLinkViewController' is unused
PaymentSheet.swift:356 warning: Function 'pay(with:)' is unused
PaymentSheet.swift:357 warning: Function 'clearTextFields()' is unused
PaymentMethodFormViewController.swift:159 warning: Function 'clearTextFields()' is unused
PaymentSheetVerticalViewController.swift:439 warning: Function 'clearTextFields()' is unusedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
wooj-stripe
reviewed
Nov 5, 2024
StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/PaymentSheet+Link.swift
Show resolved
Hide resolved
StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/PaymentSheetConfiguration.swift
Outdated
Show resolved
Hide resolved
StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/PaymentSheet.swift
Show resolved
Hide resolved
wooj-stripe
reviewed
Nov 7, 2024
Comment on lines
143
to
166
| } | ||
| } | ||
|
|
||
| func payWithLinkViewControllerDidCancel(_ payWithLinkViewController: PayWithLinkViewController) { | ||
| payWithLinkViewController.dismiss(animated: true) | ||
| } | ||
|
|
||
| func payWithLinkViewControllerDidFinish( | ||
| _ payWithLinkViewController: PayWithLinkViewController, | ||
| result: PaymentSheetResult | ||
| ) { | ||
| completion?(result) | ||
| } | ||
|
|
||
| private func findPaymentSheetViewController() -> PaymentSheetViewController? { | ||
| for vc in bottomSheetViewController.contentStack { | ||
| if let paymentSheetVC = vc as? PaymentSheetViewController { | ||
| return paymentSheetVC | ||
| } | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
| } |
There was a problem hiding this comment.
Spacing looks off here.
wooj-stripe
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Enabling testing of native Link
Testing
Tested in PS Example
Changelog
No user-facing changes