Support networking relink flows #4523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
force-pushed
the
tillh/fc-support-relink
branch
2 times, most recently
from
a25781c to
ab4ac56
Compare
|
🚨 New dead code detected in this PR: UIColor+Extensions.swift:34 warning: Property 'textBrand' is unused
UIColor+Extensions.swift:38 warning: Property 'textDisabled' is unused
UIColor+Extensions.swift:42 warning: Property 'textCritical' is unused
UIColor+Extensions.swift:50 warning: Property 'textSuccess' is unused
UIColor+Extensions.swift:70 warning: Property 'borderCritical' is unused
UIColor+Extensions.swift:90 warning: Property 'neutral0' is unused
UIColor+Extensions.swift:114 warning: Property 'neutral300' is unused
UIColor+Extensions.swift:118 warning: Property 'neutral500' is unused
UIColor+Extensions.swift:138 warning: Property 'brand100' is unused
UIColor+Extensions.swift:150 warning: Property 'critical500' is unused
UIColor+Extensions.swift:158 warning: Property 'success100' is unused
UIColor+Extensions.swift:162 warning: Property 'success500' is unused
UIColor+Extensions.swift:182 warning: Function 'dynamic(light:dark:)' is unused
DropdownFieldElement.swift:10 warning: Imported module 'StripeCore' is unused
DropdownFieldElement.swift:267 warning: Parameter 'pickerView' is unusedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
tillh-stripe
force-pushed
the
tillh/fc-support-relink
branch
from
ab4ac56 to
4c2a151
Compare
tillh-stripe
force-pushed
the
tillh/fc-repair-flow
branch
from
4e8dbe9 to
6e1a4ee
Compare
tillh-stripe
force-pushed
the
tillh/fc-support-relink
branch
2 times, most recently
from
d076bff to
820d1a7
Compare
tillh-stripe
force-pushed
the
tillh/fc-repair-flow
branch
3 times, most recently
from
94eb9fb to
841b0fa
Compare
tillh-stripe
force-pushed
the
tillh/fc-support-relink
branch
3 times, most recently
from
fcf5ba2 to
f82ae1e
Compare
- Don't return `.canceled` for networking relink sessions - Don't use custom success message in this case
tillh-stripe
force-pushed
the
tillh/fc-support-relink
branch
from
f82ae1e to
4230f28
Compare
tillh-stripe
commented
Feb 13, 2025
| id: repairSession.id, | ||
| flow: repairSession.flow, | ||
| institutionSkipAccountSelection: nil, | ||
| nextPane: .success, |
There was a problem hiding this comment.
This aligns with Web behavior.
mats-stripe
reviewed
Feb 14, 2025
| let body: [String: Any] = [ | ||
| "client_secret": clientSecret, | ||
| "core_authorization": coreAuthorization, | ||
| "return_url": "ios", |
There was a problem hiding this comment.
Confused by this parameter, why not pass the real return URL?
There was a problem hiding this comment.
That’s what we’re doing for auth session creation, too. I assume the manifest holds onto the real URL passed in the synchronize call, but will confirm.
...ions/StripeFinancialConnections/Source/API Bindings/FinancialConnectionsAsyncAPIClient.swift
Outdated
Show resolved
Hide resolved
Comment on lines
12
to
16
| let flow: FinancialConnectionsAuthSession.Flow | ||
| let url: String | ||
| let isOauth: Bool | ||
| let display: FinancialConnectionsAuthSession.Display | ||
| let institution: FinancialConnectionsInstitution |
There was a problem hiding this comment.
These fields should all be optional, according to https://stripe.sourcegraphcloud.com/stripe-internal/pay-server/-/blob/lib/bank_connections/api/resource/authorization_repair_resource.rb
...Connections/StripeFinancialConnections/Source/Native/PartnerAuth/PartnerAuthDataSource.swift
Outdated
Show resolved
Hide resolved
tillh-stripe
force-pushed
the
tillh/fc-support-relink
branch
from
7d98afd to
ad715dd
Compare
- Make repair session properties optional - Fix incorrect `maxRetries` value - Move check into `shouldRecordAuthSessionEvent()`
tillh-stripe
force-pushed
the
tillh/fc-support-relink
branch
from
ad715dd to
311c24a
Compare
mats-stripe
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds support for networking relink flows in Financial Connections and Instant Bank Payments.
We reuse the existing partner auth pane, but add an optional
relinkAuthorization: String?toPartnerAuthDataSourceImplementation. Depending on this payload, we either create an auth session or a repair session; the latter of which we then map to an auth session on the client.This pull request also includes the minor tweak to hide the secondary button in this flow.
Motivation
Testing
Changelog